Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unify constructor params #8

Open
XiaNi opened this issue Jun 26, 2020 · 0 comments
Open

unify constructor params #8

XiaNi opened this issue Jun 26, 2020 · 0 comments

Comments

@XiaNi
Copy link

XiaNi commented Jun 26, 2020

GLTFPlayer and DracosisPlayer use constructor arguments.

I think it will be better to use object and decomposition like in DepthVideoPlayer
DepthVideoPlayer ({ <constructor props>});
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@XiaNi