Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it possible to pass functions to change output streaming #116

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

thekid
Copy link
Member

@thekid thekid commented May 30, 2024

Can be used for implementing HTTP compression:

use web\Filter;
use web\io\Output;

class WriteCompressed extends Output {

  /* Implementation omitted for brevity */ 

}

class CompressResponses implements Filter {

  /* Negotiation omitted for brevity */

  public function filter($req, $res, $invocation) {
    if ($compression= $this->negotiate($req->header('Accept-Encoding'))) {
      $res->streaming(function($res) use($compression) {
        return new WriteCompressed($res, $compression);
      });
    }

    return $invocation->proceed($req, $res);
  }
}

@thekid
Copy link
Member Author

thekid commented May 30, 2024

This library is built on top of this PR: https://github.com/xp-forge/web-compression

…owing:

. WriteLength, when length !== null
. WriteChunks, for HTTP/1.1
. Buffered, otherwise

This way, we do not need to set the Content-Length header inside Response and
can prevent code duplication in various places, including streaming functions,
at the cost of a tiny overhead when writing data with a known content length.
This overhead consists of additional method calls and instantiating and later
garbage-collecting an additional object, all of which is unmeasurable compared
to the network I/O
@thekid
Copy link
Member Author

thekid commented Jun 9, 2024

This fails when nesting these calls, e.g. one filter being the developer console, and the other being compression, each of them overwriting the streaming implementation instead of nesting it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant