Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to METEOR_SETTINGS #20

Open
zvictor opened this issue Feb 24, 2016 · 2 comments
Open

Add support to METEOR_SETTINGS #20

zvictor opened this issue Feb 24, 2016 · 2 comments

Comments

@zvictor
Copy link

zvictor commented Feb 24, 2016

Based on the principles presented at http://joshowens.me/environment-settings-and-security-with-meteor-js/, we should be using METEOR_SETTINGS instead of sending our settings.json through Git.

I get an error, though:

> .scripts/test.js

[[[[[ ~/network/src ]]]]]

=> Started proxy.
=> Errors prevented startup:

   While preparing to run:
   settings.json: file not found (settings file)
@zvictor
Copy link
Author

zvictor commented Feb 25, 2016

Right now I am fixing it with the following:

test:
  pre:
    - echo $METEOR_SETTINGS > src/settings.json

I haven't tried a safer option to avoid problems when the settings.json already exists, therefore I am not creating a PR for this yet.

@ghost
Copy link

ghost commented Feb 25, 2016

I think using Object.assign instead of require('util')._extend will fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant