Skip to content

Added ability to open html in a new split. #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Dec 29, 2014
Merged

Conversation

naddeoa
Copy link
Contributor

@naddeoa naddeoa commented Dec 15, 2014

The html feature is very convenient, but I find myself wanting to view
the source code at times. Without this option, I would have to open
thefile in a browser, right click and view page source.

The html feature is very convenient, but I find myself wanting to view
the source code at times. Without this option, I would have to open
thefile in a browser, right click and view page source.
My job uses Mediawiki based wikis. This allows me to continuing using
vim-notes and share my notes when my coworkers need to see them.
@naddeoa
Copy link
Contributor Author

naddeoa commented Dec 15, 2014

This is actually my first pull request so please let me know if I should be doing more.

@xolox
Copy link
Owner

xolox commented Dec 15, 2014

Hi @naddeoa, can you document your changes to plugin/notes.vim in README.md, i.e. the change to the :NoteToHtml command and the addition of the :NoteToMediawiki command? Apart from that the pull request looks good (I'll give it another more thorough review in the coming days, but on first glance everything looks good :-)

Also updated the documentation to contain the `:NoteToHtml split`
addition.
@naddeoa
Copy link
Contributor Author

naddeoa commented Dec 18, 2014

Sorry for the delay! I just updated the documentation to contain the :NoteToMediawiki option and the split command that was added to :NoteToHtml. Let me know if you want me to touch anything up, or if you need me to explain anything. I tried to at least match the language that was in the Readme.

Anthony Naddeo added 2 commits December 22, 2014 12:59
The TODO and DONE should only be colored if they are exact case
sensitive matches. Also, only the first match should be colored.
@xolox xolox merged commit 703508d into xolox:master Dec 29, 2014
xolox added a commit that referenced this pull request Dec 29, 2014
In this merge commit I'm making a couple of minor changes:

 - The `---` sequence is now used as a horizontal divider in the
   Mediawiki syntax converter.

 - The changes to xolox#notes#html#view() created a temporary file even
   when the HTML was shown in a Vim split window, now the temporary file
   is only created when it needs to be passed to a web browser.

 - I changed some wrong indentation, removed some unused code (the
   counter variable) and renamed some private variables
   (s/hilight/highlight/g) and added word boundaries to the
   TODO/DONE/XXX matching in the file mediawiki.vim.

 - No trailing empty lines are added when a note is converted to
   Mediawiki syntax (there were in the pull request, but without context
   or explanation so I'd rather keep the Markdown, HTML and Mediawiki
   converters consistent).
@xolox
Copy link
Owner

xolox commented Dec 29, 2014

Hi @naddeoa,

I just merged your pull request and published the result as vim-notes version 0.30. I made some minor changes during the merge, I described those changes in the merge commit (ed6d6e7). You can get an overview of my changes by comparing your last commit with my merge commit.

I failed to publish the resulting ZIP archive to www.vim.org because of server side errors, but the changes are available on GitHub and will eventually be published to www.vim.org as well.

Thanks for the contribution!

@redapemusic35
Copy link

I am having trouble using the Html conversion feature and it is certainly my fault. What does it mean to say that conversion requires the 'markdown' program?

@naddeoa
Copy link
Contributor Author

naddeoa commented Jul 15, 2019

That means you need to install markdown. If you're on Ubuntu like me then that means running sudo apt install markdown. If you're on mac then you probably need to install it through home brew, which is probably brew install markdown. I'm not sure about windows.

For more help, google "install markdown". You should find a lot of links.

@redapemusic35
Copy link

I currently use vimwiki which I write in using markdown. I also use markdown and Pandoc to convert the markdown files into whatever. But I thought markdown was merely a language and not a program exactly. Imagine my surprise when I found out that I did not have markdown installed! Please forgive my ignorance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants