Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XVF3800 support #54

Merged
merged 9 commits into from
Jan 3, 2023
Merged

XVF3800 support #54

merged 9 commits into from
Jan 3, 2023

Conversation

ed-xmos
Copy link
Contributor

@ed-xmos ed-xmos commented Jan 3, 2023 •
edited
Loading

Official support for XVF3800 HW.
#53

Also addresses https://github.com/xmos/sw_xvf3800/issues/318

@ed-xmos ed-xmos self-assigned this Jan 3, 2023
@ed-xmos ed-xmos linked an issue Jan 3, 2023 that may be closed by this pull request
Add support for XVF3800 #53
Closed
@ed-xmos ed-xmos changed the base branch from master to release/v5.4.0 January 3, 2023 11:13
@ed-xmos
Copy link
Contributor Author

ed-xmos commented Jan 3, 2023 •
edited
Loading

I have tested this and can confirm the the DAC does not play until the firmware runs and the DAC_RESET_N line is being properly driven now

@mbanth mbanth added the type:enhancement New feature or request label Jan 3, 2023
@mbanth mbanth added this to the v5.4.0 milestone Jan 3, 2023
lucianomartin
lucianomartin approved these changes Jan 3, 2023
View reviewed changes
Copy link
Contributor

@lucianomartin lucianomartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

mbanth
mbanth requested changes Jan 3, 2023
View reviewed changes
Copy link

@mbanth mbanth left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition to my other comments, the setup_mclk_bclk.c file needs its copyright date updated.

README.md Outdated Show resolved Hide resolved
resources/clk_dac_setup/setup_io_exp_and_dac.py Outdated Show resolved Hide resolved
resources/clk_dac_setup/setup_io_exp_and_dac.py Outdated Show resolved Hide resolved
@ed-xmos ed-xmos requested a review from mbanth January 3, 2023 14:21
mbanth
mbanth approved these changes Jan 3, 2023
View reviewed changes
Copy link

@mbanth mbanth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@ed-xmos ed-xmos merged commit 34dc994 into xmos:release/v5.4.0 Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucianomartin lucianomartin lucianomartin approved these changes

@mbanth mbanth mbanth approved these changes

Assignees

@ed-xmos ed-xmos

Labels
type:enhancement New feature or request
Projects
None yet
Milestone
v5.4.0
Development

Successfully merging this pull request may close these issues.

Add support for XVF3800
3 participants
@ed-xmos @lucianomartin @mbanth