Skip to content

Commit 19384b3

Browse files
committed
Cleanup and few improvements
1 parent 54b105e commit 19384b3

File tree

2 files changed

+9
-18
lines changed

2 files changed

+9
-18
lines changed

.github/workflows/wheels.yml

Lines changed: 9 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -65,29 +65,26 @@ jobs:
6565
name: sdist
6666
path: dist/*.tar.gz
6767

68-
generate-wheels-matrix:
68+
generate_wheels_matrix:
6969
# Create a matrix of all architectures & versions to build.
7070
# This enables the next step to run cibuildwheel in parallel.
7171
# From https://iscinumpy.dev/post/cibuildwheel-2-10-0/#only-210
7272
name: Generate wheels matrix
73-
runs-on: ubuntu-latest
73+
runs-on: ubuntu-24.04
7474
outputs:
7575
include: ${{ steps.set-matrix.outputs.include }}
7676
steps:
7777
- uses: actions/checkout@v4
7878
- name: Install cibuildwheel
79-
# Nb. keep cibuildwheel version pin consistent with job below
80-
run: pipx install cibuildwheel==3.1.4
79+
# N.B. Keep cibuildwheel version pin consistent with "build_wheels" job below.
80+
run: pipx install cibuildwheel==3.3
8181
- id: set-matrix
82-
# Once we have the windows build figured out, it can be added here
83-
# by updating the matrix to include windows builds as well.
84-
# See example here:
85-
# https://github.com/lxml/lxml/blob/3ccc7d583e325ceb0ebdf8fc295bbb7fc8cd404d/.github/workflows/wheels.yml#L95C1-L106C51
8682
run: |
8783
MATRIX=$(
8884
{
8985
cibuildwheel --print-build-identifiers --platform linux \
90-
| jq -nRc '{"only": inputs, "os": "ubuntu-latest"}' \
86+
| jq -nRc '{"only": inputs, "os": "ubuntu-22.04"}' \
87+
| sed -e '/aarch64/s|ubuntu-22.04|ubuntu-22.04-arm|' \
9188
&& cibuildwheel --print-build-identifiers --platform macos \
9289
| jq -nRc '{"only": inputs, "os": "macos-latest"}' \
9390
&& cibuildwheel --print-build-identifiers --platform windows \
@@ -101,17 +98,13 @@ jobs:
10198
10299
build_wheels:
103100
name: Build for ${{ matrix.only }}
104-
needs: generate-wheels-matrix
101+
needs: generate_wheels_matrix
105102
runs-on: ${{ matrix.os }}
106103

107104
strategy:
108105
fail-fast: false
109106
matrix:
110-
include: ${{ fromJson(needs.generate-wheels-matrix.outputs.include) }}
111-
112-
env:
113-
PYXMLSEC_LIBXML2_VERSION: 2.14.6
114-
PYXMLSEC_LIBXSLT_VERSION: 1.1.43
107+
include: ${{ fromJson(needs.generate_wheels_matrix.outputs.include) }}
115108

116109
steps:
117110
- name: Check out the repo
@@ -126,7 +119,7 @@ jobs:
126119
platforms: all
127120

128121
- name: Build wheels
129-
uses: pypa/cibuildwheel@v3.1.4
122+
uses: pypa/cibuildwheel@v3.3
130123
with:
131124
only: ${{ matrix.only }}
132125
env:

pyproject.toml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -113,8 +113,6 @@ PYXMLSEC_STATIC_DEPS = "true"
113113
[tool.cibuildwheel.linux]
114114
archs = ["x86_64", "aarch64", "riscv64"]
115115
environment-pass = [
116-
"PYXMLSEC_LIBXML2_VERSION",
117-
"PYXMLSEC_LIBXSLT_VERSION",
118116
"PYXMLSEC_STATIC_DEPS",
119117
"GH_TOKEN"
120118
]

0 commit comments

Comments
 (0)