Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Binary packages of different vs_runtime should not be considered distinct #1347

Closed
xq114 opened this issue Apr 19, 2021 · 7 comments
Closed
Milestone

Comments

@xq114
Copy link
Contributor

xq114 commented Apr 19, 2021

注:如果是问题报障或者特性请求,请选择报告缺陷特性请求模板,否则一律不回复。

描述讨论详情

例如,windows上我依赖了binary类型的strawberry-perl,则vs_runtime=MT时安装了一遍,vs_runtime=MD的时候应该直接复用原来安装的而无需重新下载安装

@waruqi
Copy link
Member

waruqi commented Apr 19, 2021

区分还是要做的,也许有些 binary package 只支持 MD,不过 xmake-repo 里面 add_deps 包默认就是 MT 的,所以按理是没这问题的。。

只有走 xmake f --vs_runtime=MD 时候,package 的 默认 vs_runtime 配置被改写成了 MD,没走继承逻辑。。我现在改进过了。。可以再试试。。dev

@waruqi waruqi added this to the v2.5.4 milestone Apr 19, 2021
@waruqi waruqi closed this as completed Apr 20, 2021
@xq114
Copy link
Contributor Author

xq114 commented Apr 22, 2021

对于library类型的package被依赖的库确实要和依赖的库runtime保持一致,如果runtime是MD那依赖的所有library库也都应该是MD的,只有binary类型由于只调用可执行文件而不参与链接所以无需保持一致

@xq114
Copy link
Contributor Author

xq114 commented Apr 22, 2021

@waruqi
Copy link
Member

waruqi commented Apr 22, 2021

没看出什么问题,你先自己研究下好了

@xq114
Copy link
Contributor Author

xq114 commented Apr 22, 2021

没看出什么问题,你先自己研究下好了

就是这里openvdb是MD,依赖的boost也应该是MD,但这里实际安装的boost是MT
image

@waruqi
Copy link
Member

waruqi commented Apr 22, 2021

稍微改了下,等 dev ci跑完再试试

@waruqi
Copy link
Member

waruqi commented Apr 23, 2021

昨天改的有问题,我更新了下,一会再试试

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants