Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Refactor]: startup process #629

Closed
1 task done
themanforfree opened this issue Jan 23, 2024 · 0 comments · Fixed by #624
Closed
1 task done

[Refactor]: startup process #629

themanforfree opened this issue Jan 23, 2024 · 0 comments · Fixed by #624
Labels
enhancement New feature or request
Milestone
v0.7.0

Comments

@themanforfree
Copy link
Collaborator

Description about the feature

Currently, before XlineServer starts, we need to get information such as cluster_info and db, and these logics are scattered in the main and test cluster implementations, if these logics changed, we need to modify multiple locations, which is a very bad implementation, so we need to refactor the XlineServer startup logic and use the same sub-methods in all locations

Code of Conduct

  • I agree to follow this project's Code of Conduct
@themanforfree themanforfree added the enhancement New feature or request label Jan 23, 2024
@themanforfree themanforfree added this to the v0.7.0 milestone Jan 23, 2024
@themanforfree themanforfree linked a pull request Jan 23, 2024 that will close this issue
[Refactor]: optimized the Xline startup process #624
Merged
@mergify mergify bot closed this as completed in #624 Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v0.7.0
Development

Successfully merging a pull request may close this issue.

[Refactor]: optimized the Xline startup process themanforfree/Xline
1 participant
@themanforfree