Pass function pointer instead of ¶meter #30
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this commit, a pointer to the stack was passed as the function
pointer. If you passed
nil
as a function pointer, for example, apointer to the stack was being passed.
This fix is not thorough and I don't actually want to call a CB, so I
have not checked that it works for that use case. I have not dived in to
discover if there is a better way to make this work, I could use a hand
here improving this fix.
I note that there exists a function pointer type (
CB
below), which hasa
PassRef
/PassValue
methods. Maybe those should be called?Before:
After: