Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pretraining with im_start_end token #18

Open
Ali2500 opened this issue Aug 21, 2024 · 0 comments
Open

Pretraining with im_start_end token #18

Ali2500 opened this issue Aug 21, 2024 · 0 comments

Comments

@Ali2500
Copy link

Ali2500 commented Aug 21, 2024

I wanted to know why the prepare_input_labels_for_multimodal function in llava_arch.py is designed to throw an exception during pretraining if the mm_use_im_start_end option is enabled:

# TODO: image start / end is not implemented here to support pretraining.
if getattr(self.config, 'tune_mm_mlp_adapter', False) and getattr(self.config, 'mm_use_im_start_end', False):
    raise NotImplementedError

Shouldn't the function work fine even if there are <im_start> and <im_end> tokens around the image tokens?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant