From 37e4154cf17d428641f2300b2c47b80f3792461a Mon Sep 17 00:00:00 2001
From: Sumit Kumar <sumit@appsmith.com>
Date: Thu, 6 Jul 2023 16:32:17 +0530
Subject: [PATCH] fix: update placeholder text for port numbers in datasource
 form  (#24961)

---
 .../Port_Number_Placeholder_Spec.ts           | 41 +++++++++++++++++++
 .../mssqlPlugin/src/main/resources/form.json  |  2 +-
 .../oraclePlugin/src/main/resources/form.json |  2 +-
 .../smtpPlugin/src/main/resources/form.json   |  2 +-
 4 files changed, 44 insertions(+), 3 deletions(-)
 create mode 100644 app/client/cypress/e2e/Sanity/Datasources/Port_Number_Placeholder_Spec.ts

diff --git a/app/client/cypress/e2e/Sanity/Datasources/Port_Number_Placeholder_Spec.ts b/app/client/cypress/e2e/Sanity/Datasources/Port_Number_Placeholder_Spec.ts
new file mode 100644
index 000000000000..b35de8b1e153
--- /dev/null
+++ b/app/client/cypress/e2e/Sanity/Datasources/Port_Number_Placeholder_Spec.ts
@@ -0,0 +1,41 @@
+import { agHelper, dataSources } from "../../../support/Objects/ObjectsCore";
+
+describe("Test placeholder value for port number for all datasources - tests #24960", () => {
+  it("1. Test datasource port number placeholder", () => {
+    // MsSQL
+    dataSources.NavigateToDSCreateNew();
+    dataSources.CreatePlugIn("Microsoft SQL Server");
+
+    let expectedPlaceholderValue = "1433";
+    agHelper.AssertAttribute(
+      dataSources._port,
+      "placeholder",
+      expectedPlaceholderValue,
+    );
+    dataSources.SaveDSFromDialog(false);
+
+    // Oracle
+    dataSources.NavigateToDSCreateNew();
+    dataSources.CreatePlugIn("Oracle");
+
+    expectedPlaceholderValue = "1521";
+    agHelper.AssertAttribute(
+      dataSources._port,
+      "placeholder",
+      expectedPlaceholderValue,
+    );
+    dataSources.SaveDSFromDialog(false);
+
+    // SMTP
+    dataSources.NavigateToDSCreateNew();
+    dataSources.CreatePlugIn("SMTP");
+
+    expectedPlaceholderValue = "25";
+    agHelper.AssertAttribute(
+      dataSources._port,
+      "placeholder",
+      expectedPlaceholderValue,
+    );
+    dataSources.SaveDSFromDialog(false);
+  });
+});
diff --git a/app/server/appsmith-plugins/mssqlPlugin/src/main/resources/form.json b/app/server/appsmith-plugins/mssqlPlugin/src/main/resources/form.json
index 152c64272a0f..7909b07a147d 100644
--- a/app/server/appsmith-plugins/mssqlPlugin/src/main/resources/form.json
+++ b/app/server/appsmith-plugins/mssqlPlugin/src/main/resources/form.json
@@ -37,7 +37,7 @@
               "configProperty": "datasourceConfiguration.endpoints[*].port",
               "dataType": "NUMBER",
               "controlType": "KEYVALUE_ARRAY",
-              "placeholderText": "1443"
+              "placeholderText": "1433"
             }
           ]
         },
diff --git a/app/server/appsmith-plugins/oraclePlugin/src/main/resources/form.json b/app/server/appsmith-plugins/oraclePlugin/src/main/resources/form.json
index f3dd69ea7676..6750eccf18e0 100755
--- a/app/server/appsmith-plugins/oraclePlugin/src/main/resources/form.json
+++ b/app/server/appsmith-plugins/oraclePlugin/src/main/resources/form.json
@@ -21,7 +21,7 @@
               "configProperty": "datasourceConfiguration.endpoints[*].port",
               "dataType": "NUMBER",
               "controlType": "KEYVALUE_ARRAY",
-              "placeholderText": "6003"
+              "placeholderText": "1521"
             }
           ]
         },
diff --git a/app/server/appsmith-plugins/smtpPlugin/src/main/resources/form.json b/app/server/appsmith-plugins/smtpPlugin/src/main/resources/form.json
index 637f9f0f2582..08878f60a12a 100644
--- a/app/server/appsmith-plugins/smtpPlugin/src/main/resources/form.json
+++ b/app/server/appsmith-plugins/smtpPlugin/src/main/resources/form.json
@@ -20,7 +20,7 @@
               "configProperty": "datasourceConfiguration.endpoints[*].port",
               "dataType": "NUMBER",
               "controlType": "KEYVALUE_ARRAY",
-              "placeholderText": "587"
+              "placeholderText": "25"
             }
           ]
         }