From 208291549b8ea661d87a2951e129f36d79c3aff0 Mon Sep 17 00:00:00 2001 From: Vishnu Gp Date: Wed, 5 Jul 2023 14:10:20 +0530 Subject: [PATCH] fix: Changes to fix CE test failure on EE (#25102) ## Description This PR fixes the TenantServiceCETest failure that happens on EE codebase #### Type of change - Bug fix (non-breaking change which fixes an issue) > > > ## Testing > #### How Has This Been Tested? > Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration. > Delete anything that is not relevant - [ ] Manual - [ ] Jest - [ ] Cypress > > #### Test Plan > Add Testsmith test cases links that relate to this PR > > #### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) > > > ## Checklist: #### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed --- .../services/ce/TenantServiceCETest.java | 18 ++++++++++++++++-- 1 file changed, 16 insertions(+), 2 deletions(-) diff --git a/app/server/appsmith-server/src/test/java/com/appsmith/server/services/ce/TenantServiceCETest.java b/app/server/appsmith-server/src/test/java/com/appsmith/server/services/ce/TenantServiceCETest.java index 296a20b80f5a..e5807601ed1c 100644 --- a/app/server/appsmith-server/src/test/java/com/appsmith/server/services/ce/TenantServiceCETest.java +++ b/app/server/appsmith-server/src/test/java/com/appsmith/server/services/ce/TenantServiceCETest.java @@ -1,13 +1,18 @@ package com.appsmith.server.services.ce; import com.appsmith.server.constants.LicensePlan; +import com.appsmith.server.domains.Tenant; +import com.appsmith.server.domains.TenantConfiguration; import com.appsmith.server.services.TenantService; +import org.junit.jupiter.api.BeforeEach; import org.junit.jupiter.api.Test; import org.junit.jupiter.api.extension.ExtendWith; -import org.springframework.beans.factory.annotation.Autowired; +import org.mockito.Mockito; import org.springframework.boot.test.context.SpringBootTest; +import org.springframework.boot.test.mock.mockito.SpyBean; import org.springframework.security.test.context.support.WithUserDetails; import org.springframework.test.context.junit.jupiter.SpringExtension; +import reactor.core.publisher.Mono; import reactor.test.StepVerifier; import static org.assertj.core.api.Assertions.assertThat; @@ -16,9 +21,18 @@ @SpringBootTest @ExtendWith(SpringExtension.class) public class TenantServiceCETest { - @Autowired + @SpyBean TenantService tenantService; + @BeforeEach + void setup() { + Tenant tenant = new Tenant(); + TenantConfiguration tenantConfiguration = new TenantConfiguration(); + tenant.setTenantConfiguration(tenantConfiguration); + + Mockito.when(tenantService.getDefaultTenant()).thenReturn(Mono.just(tenant)); + } + @Test @WithUserDetails("anonymousUser") public void getTenantConfig_Valid_AnonymousUser() {