fix(native-image): do not initialize logging framework at build-time

Author: kkriske

pom.xml

@@ -365,7 +365,6 @@
                                 -->
                                 <buildArg>
                                     -H:ServiceLoaderFeatureExcludeServiceProviders=com.tngtech.archunit.junit.internal.ArchUnitTestEngine
-                                    --initialize-at-build-time=ch.qos.logback
                                 </buildArg>
                             </buildArgs>
                         </configuration>
@@ -396,9 +395,7 @@
                         <artifactId>native-maven-plugin</artifactId>
                         <configuration>
                             <buildArgs combine.children="append">
-                                <buildArg>
-                                    -Dorg.sqlite.lib.exportPath=${project.build.directory}
-                                </buildArg>
+                                <buildArg>-Dorg.sqlite.lib.exportPath=${project.build.directory}</buildArg>
                             </buildArgs>
                         </configuration>
                     </plugin>

src/main/java/org/sqlite/SQLiteJDBCLoader.java

@@ -398,7 +398,6 @@ public static String getVersion() {
      * executable, and we're eliminating the IO operations as well.
      */
     public static final class VersionHolder {
-        private static final Logger logger = LoggerFactory.getLogger(VersionHolder.class);
         private static final String VERSION;
 
         static {
@@ -420,7 +419,10 @@ public static final class VersionHolder {
                     version = version.trim().replaceAll("[^0-9\\.]", "");
                 }
             } catch (IOException e) {
-                logger.atError()
+                // inline creation of logger to avoid build-time initialization of the logging
+                // framework in native-image
+                LoggerFactory.getLogger(VersionHolder.class)
+                        .atError()
                         .setCause(e)
                         .log("Could not read version from file: {}", versionFile);
             }

src/main/java/org/sqlite/jdbc3/JDBC3DatabaseMetaData.java

@@ -31,7 +31,6 @@
 import org.sqlite.util.StringUtils;
 
 public abstract class JDBC3DatabaseMetaData extends CoreDatabaseMetaData {
-    private static final Logger logger = LoggerFactory.getLogger(JDBC3DatabaseMetaData.class);
 
     private static String driverName;
     private static String driverVersion;
@@ -965,14 +964,14 @@ public ResultSet getColumns(String c, String s, String tblNamePattern, String co
                         try {
                             rsColAutoinc.close();
                         } catch (Exception e) {
-                            logger.atError().setCause(e).log();
+                            LogHolder.logger.atError().setCause(e).log();
                         }
                     }
                     if (statColAutoinc != null) {
                         try {
                             statColAutoinc.close();
                         } catch (Exception e) {
-                            logger.atError().setCause(e).log();
+                            LogHolder.logger.atError().setCause(e).log();
                         }
                     }
                 }
@@ -1123,7 +1122,7 @@ public ResultSet getColumns(String c, String s, String tblNamePattern, String co
                 try {
                     rs.close();
                 } catch (Exception e) {
-                    logger.atError().setCause(e).log();
+                    LogHolder.logger.atError().setCause(e).log();
                 }
             }
         }
@@ -2240,4 +2239,12 @@ private String unquoteIdentifier(String name) {
         }
         return name;
     }
+
+    /**
+     * Class-wrapper around the logger object to avoid build-time initialization of the logging
+     * framework in native-image
+     */
+    private static class LogHolder {
+        private static final Logger logger = LoggerFactory.getLogger(JDBC3DatabaseMetaData.class);
+    }
 }

src/main/java/org/sqlite/util/OSInfo.java

@@ -40,7 +40,6 @@
  * @author leo
  */
 public class OSInfo {
-    private static final Logger logger = LoggerFactory.getLogger(OSInfo.class);
     protected static ProcessRunner processRunner = new ProcessRunner();
     private static final HashMap<String, String> archMapping = new HashMap<>();
 
@@ -161,7 +160,7 @@ static String getHardwareName() {
         try {
             return processRunner.runAndWaitFor("uname -m");
         } catch (Throwable e) {
-            logger.atError().setCause(e).log("Error while running uname -m");
+            LogHolder.logger.atError().setCause(e).log("Error while running uname -m");
             return "unknown";
         }
     }
@@ -222,7 +221,8 @@ static String resolveArmArchType() {
                         return "armv7";
                     }
                 } else {
-                    logger.atWarn()
+                    LogHolder.logger
+                            .atWarn()
                             .log(
                                     "readelf not found. Cannot check if running on an armhf system, armel architecture will be presumed");
                 }
@@ -272,4 +272,12 @@ static String translateOSNameToFolderName(String osName) {
     static String translateArchNameToFolderName(String archName) {
         return archName.replaceAll("\\W", "");
     }
+
+    /**
+     * Class-wrapper around the logger object to avoid build-time initialization of the logging
+     * framework in native-image
+     */
+    private static class LogHolder {
+        private static final Logger logger = LoggerFactory.getLogger(OSInfo.class);
+    }
 }

src/main/java9/org/sqlite/nativeimage/SqliteJdbcFeature.java

@@ -4,7 +4,6 @@
 import org.graalvm.nativeimage.hosted.RuntimeClassInitialization;
 import org.graalvm.nativeimage.hosted.RuntimeJNIAccess;
 import org.graalvm.nativeimage.hosted.RuntimeResourceAccess;
-import org.slf4j.LoggerFactory;
 import org.sqlite.*;
 import org.sqlite.core.DB;
 import org.sqlite.core.NativeDB;
@@ -29,7 +28,6 @@ public void beforeAnalysis(BeforeAnalysisAccess a) {
         RuntimeClassInitialization.initializeAtBuildTime(JDBC3DatabaseMetaData.class);
         RuntimeClassInitialization.initializeAtBuildTime(OSInfo.class);
         RuntimeClassInitialization.initializeAtBuildTime(LibraryLoaderUtil.class);
-        RuntimeClassInitialization.initializeAtBuildTime(LoggerFactory.class);
         a.registerReachabilityHandler(
                 this::nativeDbReachable, method(SQLiteJDBCLoader.class, "initialize"));
     }