refactor: remove the deprecated TransactionMode.DEFFERED

the deprecation was added in October 2018

BREAKING-CHANGE: no more backward compatibility when using the deprecated enum value

Author: gotson

src/main/java/org/sqlite/SQLiteConfig.java

@@ -1084,9 +1084,6 @@ public void setApplicationId(int id) {
     }
 
     public enum TransactionMode implements PragmaValue {
-        /** @deprecated Use {@code DEFERRED} instead. */
-        @Deprecated
-        DEFFERED, // cspell:disable-line
         DEFERRED,
         IMMEDIATE,
         EXCLUSIVE;
@@ -1096,9 +1093,6 @@ public String getValue() {
         }
 
         public static TransactionMode getMode(String mode) {
-            if ("DEFFERED".equalsIgnoreCase(mode)) { // cspell:disable-line
-                return DEFERRED;
-            }
             return TransactionMode.valueOf(mode.toUpperCase());
         }
     }

src/main/java/org/sqlite/SQLiteConnectionConfig.java

@@ -121,9 +121,6 @@ public SQLiteConfig.TransactionMode getTransactionMode() {
 
     @SuppressWarnings("deprecation")
     public void setTransactionMode(SQLiteConfig.TransactionMode transactionMode) {
-        if (transactionMode == SQLiteConfig.TransactionMode.DEFFERED) { // cspell:disable-line
-            transactionMode = SQLiteConfig.TransactionMode.DEFERRED;
-        }
         this.transactionMode = transactionMode;
     }
 

src/main/java/org/sqlite/jdbc3/JDBC3Connection.java

@@ -57,9 +57,7 @@ public void tryEnforceTransactionMode() throws SQLException {
                 // (note: this pragma is evaluated on a per-transaction basis by SQLite)
                 getDatabase()._exec("PRAGMA query_only = true;");
             } else {
-                if (getCurrentTransactionMode() == TransactionMode.DEFERRED
-                        || this.getCurrentTransactionMode()
-                                == TransactionMode.DEFFERED) { // cspell:disable-line
+                if (getCurrentTransactionMode() == TransactionMode.DEFERRED) {
                     if (isFirstStatementExecuted()) {
                         // first statement was already executed; cannot upgrade to write
                         // transaction!

src/test/java/org/sqlite/TransactionTest.java

@@ -355,21 +355,6 @@ public void transactionModes(@TempDir File tempDir) throws Exception {
             assertThat(con.getConnectionConfig().transactionPrefix()).isEqualTo("begin;");
         }
 
-        // Misspelled deferred should be accepted for backwards compatibility
-        ds.setTransactionMode("DEFFERED");
-        try (SQLiteConnection con = (SQLiteConnection) ds.getConnection()) {
-            assertThat(con.getConnectionConfig().getTransactionMode())
-                    .isEqualTo(TransactionMode.DEFERRED);
-            assertThat(con.getConnectionConfig().transactionPrefix()).isEqualTo("begin;");
-        }
-
-        try (SQLiteConnection con = (SQLiteConnection) ds.getConnection()) {
-            con.getConnectionConfig().setTransactionMode(TransactionMode.valueOf("DEFFERED"));
-            assertThat(con.getConnectionConfig().getTransactionMode())
-                    .isEqualTo(TransactionMode.DEFERRED);
-            assertThat(con.getConnectionConfig().transactionPrefix()).isEqualTo("begin;");
-        }
-
         // immediate
         ds.setTransactionMode(TransactionMode.IMMEDIATE.name());
         try (SQLiteConnection con = (SQLiteConnection) ds.getConnection()) {