Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sbt-pack should not pack dependencies in aggregation modules. #67

Closed
clockfly opened this issue Mar 27, 2015 · 8 comments
Closed

sbt-pack should not pack dependencies in aggregation modules. #67

clockfly opened this issue Mar 27, 2015 · 8 comments
Assignees
Labels

Comments

@clockfly
Copy link

  lazy val root = Project(
    id = "root",
    base = file("."),
    settings = commonSettings ++
      packSettings
  ).dependsOn(module1)
   .aggregate(module1, module2)

Dependencies jars in module2 should not be copied to generated package.

@clockfly
Copy link
Author

I saw some one reported this one year ago, is this issue still target to be fixed in 0.6.x?
#31

@tolikr
Copy link

tolikr commented Aug 22, 2017

Is this fixed? In 0.9.0 issue is still exists.

@xerial
Copy link
Owner

xerial commented Sep 14, 2017

Not yet. This will change the behavior of sbt-pack, so it will be 0.10.x or so

@tolikr
Copy link

tolikr commented Sep 14, 2017

I have a project with such structures:
val x = (project in file('x')) depends on xz
val z = (project in file('z')) depends on xz
val xz = (project in file('xz'))
If i use pack version 0.8.2:
I have in all projects x,y,xz in pack directory right dependencies.
But after 0.8.2, in 0.9.1 for example. Picture has changed:
in x/target/pack i have z project. It shouldn't be there. I tried to fix this by turn off aggregation in root project but this breaks all packs.

So i have to use 0.8.2.

@allanrenucci
Copy link

We are currently using sbt-pack in Dotty and this issue prevents us from upgrading to sbt1

@xerial
Copy link
Owner

xerial commented Jan 10, 2018

@allanrenucci That's bad. I'll check how to avoid this issue in sbt-pack side.

@xerial
Copy link
Owner

xerial commented Jan 10, 2018

@clockfly @allanrenucci Just created a new version sbt-pack 0.10.0, which probably fixes this issue. From this version sbt-pack only includes dependent modules specified by dependsOn.

@xerial xerial added the bug label Jan 10, 2018
@xerial
Copy link
Owner

xerial commented Jan 10, 2018

Let me close this issue now that 0.10.0 is on Maven central. If you still have this issue, let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants