Implement debug functions for Linux #1435
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwrsandman
force-pushed
the
linux_debug
branch
from
ae462e0 to
2a7e143
Compare
bwrsandman
force-pushed
the
linux_debug
branch
from
2a7e143 to
ac78acb
Compare
bwrsandman
force-pushed
the
linux_debug
branch
from
ac78acb to
a7649a5
Compare
bwrsandman
force-pushed
the
linux_debug
branch
from
a7649a5 to
46fabca
Compare
DrChat
requested changes
Feb 13, 2020
Member
DrChat
left a comment
DrChat
left a comment
There was a problem hiding this comment.
Looks great! Just one change requested.
bwrsandman
force-pushed
the
linux_debug
branch
2 times, most recently
from
2807ad6 to
d1dc554
Compare
CDAGaming
added a commit
to CDAGaming/xenia-canary
that referenced
this pull request
Mar 31, 2020
JoelLinn
suggested changes
Nov 7, 2020
Member
JoelLinn
left a comment
JoelLinn
left a comment
There was a problem hiding this comment.
Although it's a small changeset, I tested all these functions and there indeed was an issue. With that fixed everything works.
My recommendation is to merge this immediately after the typo is fixed.
bwrsandman
force-pushed
the
linux_debug
branch
from
ee4a865 to
a87a414
Compare
Check TracerPid in /proc/self/status for attached debugger. Add SIGTRAP handler to prevent signal from halting app while not running in a debugger. Log DebugPrint in clog (stderr).
bwrsandman
force-pushed
the
linux_debug
branch
from
a87a414 to
4e9d123
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check
TracerPidin/proc/self/statusfor attached debugger.Add
SIGTRAPhandler to prevent signal from halting app while not runningin a debugger.
Log
DebugPrintinclog(stderr).