Skip to content

Commit c0fb300

Browse files
JoelLinngibbed
authored andcommitted
[Kernel] Remove explicit SHIM calling convention
Shim exports are called from GuestToHostThunk which dictates the calling convention. The default system calling convention is different depending on OS (Windows vs. everything else) and architecture. PR #1339 addresses this for x64 Linux. There is no reason for explicit `__cdecl`. Also, it is not available in GCC. We could use `__attribute__((ms_abi))` or `__attribute__((sysv_abi))` but that just adds complexity.
1 parent 07a060b commit c0fb300

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/xenia/kernel/util/shim_utils.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ namespace kernel {
2929

3030
using PPCContext = xe::cpu::ppc::PPCContext;
3131

32-
#define SHIM_CALL void __cdecl
32+
#define SHIM_CALL void
3333
#define SHIM_SET_MAPPING(library_name, export_name, shim_data) \
3434
export_resolver->SetFunctionMapping( \
3535
library_name, ordinals::export_name, \

0 commit comments

Comments
 (0)