[fs linux]: Simplify terniary expressions to bool

bwrsandman · bwrsandman · commit 75849c82d6d9 · 2021-05-17T11:15:43.000-04:00
diff --git a/src/xenia/base/filesystem_posix.cc b/src/xenia/base/filesystem_posix.cc
@@ -141,16 +141,16 @@ class PosixFileHandle : public FileHandle {
             size_t* out_bytes_read) override {
     ssize_t out = pread(handle_, buffer, buffer_length, file_offset);
     *out_bytes_read = out;
-    return out >= 0 ? true : false;
+    return out >= 0;
   }
   bool Write(size_t file_offset, const void* buffer, size_t buffer_length,
              size_t* out_bytes_written) override {
     ssize_t out = pwrite(handle_, buffer, buffer_length, file_offset);
     *out_bytes_written = out;
-    return out >= 0 ? true : false;
+    return out >= 0;
   }
   bool SetLength(size_t length) override {
-    return ftruncate(handle_, length) >= 0 ? true : false;
+    return ftruncate(handle_, length) >= 0;
   }
   void Flush() override { fsync(handle_); }
 

Original file line number	Diff line number	Diff line change
`@@ -141,16 +141,16 @@ class PosixFileHandle : public FileHandle {`
`141`	`141`	`size_t* out_bytes_read) override {`
`142`	`142`	`ssize_t out = pread(handle_, buffer, buffer_length, file_offset);`
`143`	`143`	`*out_bytes_read = out;`
`144`		`- return out >= 0 ? true : false;`
	`144`	`+ return out >= 0;`
`145`	`145`	`}`
`146`	`146`	`bool Write(size_t file_offset, const void* buffer, size_t buffer_length,`
`147`	`147`	`size_t* out_bytes_written) override {`
`148`	`148`	`ssize_t out = pwrite(handle_, buffer, buffer_length, file_offset);`
`149`	`149`	`*out_bytes_written = out;`
`150`		`- return out >= 0 ? true : false;`
	`150`	`+ return out >= 0;`
`151`	`151`	`}`
`152`	`152`	`bool SetLength(size_t length) override {`
`153`		`- return ftruncate(handle_, length) >= 0 ? true : false;`
	`153`	`+ return ftruncate(handle_, length) >= 0;`
`154`	`154`	`}`
`155`	`155`	`void Flush() override { fsync(handle_); }`
`156`	`156`