From 45bb9624e629484702f3fcb9bf1411fc439ee608 Mon Sep 17 00:00:00 2001
From: George <Shaptic@users.noreply.github.com>
Date: Fri, 10 Sep 2021 13:56:36 -0700
Subject: [PATCH] Clarify possible `trade_type` filter values in README. (#706)

---
 .github/workflows/npm_publish.yml | 4 ++--
 CHANGELOG.md                      | 2 +-
 test/integration/apiary.js        | 6 +++---
 3 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/.github/workflows/npm_publish.yml b/.github/workflows/npm_publish.yml
index fa16466ce..8d814df57 100644
--- a/.github/workflows/npm_publish.yml
+++ b/.github/workflows/npm_publish.yml
@@ -20,9 +20,9 @@ jobs:
         run: yarn
 
       - name: Build
-        run: gulp
+        run: yarn version
 
       - name: Publish npm package
-        run: npm unpublish stellar-sdk@v9.0.0 && yarn publish --tag beta
+        run: yarn publish --tag beta
         env:
           NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
diff --git a/CHANGELOG.md b/CHANGELOG.md
index 70887de26..86f3448d8 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -22,7 +22,7 @@ This beta release adds **support for Automated Market Makers**. For details, you
   * `/liquidity_pools/:id/effects`
 
 - Expanded the `TradesCallBuilder` to support fetching liquidity pool trades and accepts a new `trade_type` filter ([#685](https://github.com/stellar/js-stellar-sdk/pull/685)):
-  * `/trades?trade_type={orderbook,liquidity_pools}`
+  * `/trades?trade_type={orderbook,liquidity_pools,all}`. By default, the filter is `all`, including both liquidity pool and orderbook records.
   * A liquidity pool trade contains the following fields:
     - `liquidity_pool_fee_bp`: LP fee expressed in basis points, and *either*
     - `base_liquidity_pool_id` or `counter_liquidity_pool_id`
diff --git a/test/integration/apiary.js b/test/integration/apiary.js
index 464ab92f3..4c09bbc7b 100644
--- a/test/integration/apiary.js
+++ b/test/integration/apiary.js
@@ -5,7 +5,7 @@
 // https://docs.google.com/document/d/1pXL8kr1a2vfYSap9T67R-g72B_WWbaE1YsLMa04OgoU/edit
 const _ = require("lodash");
 
-const MOCK_SERVER = "http://private-anon-a06e1b25a0-ammmock.apiary-mock.com";
+const MOCK_SERVER = "https://private-d133c-ammmock.apiary-mock.com";
 
 describe("tests the /liquidity_pools endpoint", function() {
   const lpId = "0569b19c75d7ecadce50501fffad6fe8ba4652455df9e1cc96dc408141124dd5";
@@ -55,7 +55,7 @@ describe("tests the /liquidity_pools endpoint", function() {
   };
 
   Object.keys(testCases).forEach(suffix => {
-    it(`GET /<id>/${suffix}`, function(done) {
+    it(`GET /<pool-id>/${suffix}`, function(done) {
       chai.request(MOCK_SERVER)
         .get(`/liquidity_pools/${lpId}/${suffix}`)
         .end(function(err, res) {
@@ -129,7 +129,7 @@ describe("tests the /accounts endpoint", function() {
       });
   });
 
-  it('GET /<id>', function(done) {
+  it('GET /<account-id>', function(done) {
     const accountId = "GDQNY3PBOJOKYZSRMK2S7LHHGWZIUISD4QORETLMXEWXBI7KFZZMKTL3";
 
     chai.request(MOCK_SERVER)