Skip to content

feat: use proper tempfiles in {de,}serialize #204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dpaetzel wants to merge 2 commits into
base: master
Choose a base branch
from
Open

feat: use proper tempfiles in {de,}serialize #204

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
beb78b1
Use proper tempfiles in {de,}serialize
dpaetzel Jul 23, 2025
c194805
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Aug 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 21 additions & 4 deletions xcsf/pybind_wrapper.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -649,8 +649,16 @@ class XCS
py::bytes
serialize() const
{
// Write XCSF to a temporary binary file
const char *filename = "_tmp_pickle.bin";
// Create a unique temporary file in /tmp. The file name is made unique
// in place by mkstemp.
char filename[] = "/tmp/xcsf_pickle_XXXXXX";
int fd = mkstemp(filename);
if (fd == -1) {
throw std::runtime_error(
"Failed to create temporary file in serialize");
}
close(fd);

xcsf_save(&xcs, filename);
// Read the binary file into bytes
std::ifstream file(filename, std::ios::binary);
Expand All @@ -673,8 +681,17 @@ class XCS
static XCS
deserialize(const py::bytes &state)
{
// Write the XCSF bytes to a temporary binary file
const char *filename = "_tmp_pickle.bin";
// Create a unique temporary file in /tmp. The file name is made unique
// in place by mkstemp.
char filename[] = "/tmp/xcsf_pickle_XXXXXX";
int fd = mkstemp(filename);
if (fd == -1) {
throw std::runtime_error(
"Failed to create temporary file in deserialize");
}
close(fd);

// Write the XCSF bytes to the temporary file.
std::ofstream file(filename, std::ios::binary);
file.write(state.cast<std::string>().c_str(),
state.cast<std::string>().size());
Expand Down
Loading