Merge pull request jenkinsci#68 from mrwanny/enable_tags

build when tags are pushed

Author: bassrock

README.md

@@ -61,6 +61,15 @@ Triggers from push events may be filtered based on the branch name, i.e. the bui
 
 This functionality requires accessing the Gitlab server (see [above](#configuring-access-to-gitlab)) and for the time being also a git repository url already saved in the project configuration. In other words, when creating a new project, the configuration needs to be saved *once* before being able to select the allowed branches. For existing projects, all branches are allowed to push by default.
 
+Build Tags
+================
+
+In order to build when a new tag is pushed:
+* In the ``GitLab server`` add ``Tag push events`` to the ``Web Hook``
+* In the ``Jenkins`` under the ``Source Code Management`` section:
+    * select ``Advance...`` and add  ``+refs/tags/*:refs/remotes/origin/tags/*`` as ``Refspec``
+    * you can also use ``Branch Specifier`` to specify which tag need to be built (exampple ``refs/tags/${TAGNAME}``)
+
 Parameterized builds
 ====================
 

src/main/java/com/dabsquared/gitlabjenkins/GitLabPushRequest.java

@@ -26,6 +26,7 @@ public GitLabPushRequest() {
 
     private String before;
     private String after;
+    private String checkout_sha;
     private String ref;
     private Integer user_id;
     private String user_name;
@@ -117,6 +118,14 @@ public String toString() {
         return ToStringBuilder.reflectionToString(this, ToStringStyle.MULTI_LINE_STYLE);
     }
 
+    public String getCheckout_sha() {
+        return checkout_sha;
+    }
+
+    public void setCheckout_sha(String checkout_sha) {
+        this.checkout_sha = checkout_sha;
+    }
+
     public static class Repository {
 
         private String name;

src/main/java/com/dabsquared/gitlabjenkins/GitLabPushTrigger.java

@@ -119,7 +119,12 @@ public void run() {
 
                 private GitLabPushCause createGitLabPushCause(GitLabPushRequest req) {
                     GitLabPushCause cause;
-                    String triggeredByUser = req.getCommits().get(0).getAuthor().getName();
+                    String triggeredByUser;
+                    if (req.getCommits().size() > 0){
+                        triggeredByUser = req.getCommits().get(0).getAuthor().getName();
+                    } else {
+                        triggeredByUser = req.getUser_name();
+                    }
                     try {
                         cause = new GitLabPushCause(triggeredByUser, getLogFile());
                     } catch (IOException ex) {
@@ -139,17 +144,28 @@ private Action[] createActions(GitLabPushRequest req) {
                     values.put("gitlabSourceBranch", new StringParameterValue("gitlabSourceBranch", branch));
                     values.put("gitlabTargetBranch", new StringParameterValue("gitlabTargetBranch", branch));
                     values.put("gitlabBranch", new StringParameterValue("gitlabBranch", branch));
-                    
-                    LOGGER.log(Level.INFO, "Trying to get name and URL for job: {0} using project {1} (push)", new String[]{job.getName(), getDesc().project.getName()});
+
+                    LOGGER.log(Level.INFO, "Trying to get name and URL for job: {0} using project {1} (push)", new String[]{job.getName(), job.getRootProject().getName()});
                     values.put("gitlabSourceRepoName", new StringParameterValue("gitlabSourceRepoName", getDesc().getSourceRepoNameDefault(job)));
                 	values.put("gitlabSourceRepoURL", new StringParameterValue("gitlabSourceRepoURL", getDesc().getSourceRepoURLDefault(job).toString()));
 
                     List<ParameterValue> listValues = new ArrayList<ParameterValue>(values.values());
 
                     ParametersAction parametersAction = new ParametersAction(listValues);
                     actions.add(parametersAction);
+                    RevisionParameterAction revision;
+
+                    if (req.getLastCommit() !=null) {
+                        revision = new RevisionParameterAction(req.getLastCommit().getId());
+                    }else{
+                        if (req.getCheckout_sha().contains("0000000000000000000000000000000000000000") ){
+                            // no commit and no checkout sha, a Tag was deleted, so no build need to be triggered
+                            LOGGER.log(Level.INFO, "GitLab Push {0} has been deleted, skip build .", req.getRef());
+                            return null;
+                        }
+                        revision = new RevisionParameterAction(req.getCheckout_sha());
+                    }
 
-                    RevisionParameterAction revision = new RevisionParameterAction(req.getLastCommit().getId());
                     actions.add(revision);
                     Action[] actionsArray = actions.toArray(new Action[0]);