Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show version snapshots in xbatcher's readthedocs page #135

Closed
weiji14 opened this issue Dec 5, 2022 · 6 comments
Closed

Show version snapshots in xbatcher's readthedocs page #135

weiji14 opened this issue Dec 5, 2022 · 6 comments

Comments

@weiji14
Copy link
Member

weiji14 commented Dec 5, 2022

Is your feature request related to a problem?

Currently at https://xbatcher.readthedocs.io/en/latest/api.html, there are only 'latest' and 'stable' versions of the documentation to switch between. With 'latest' being what's on xbatcher's 'main' branch, and 'stable' being the last release (v0.2.0).

image

Describe the solution you'd like

Each tagged version should have it's own documentation page. E.g. in xarray at https://docs.xarray.dev/en/v2022.12.0, it is possible to show the documentation for different release versions
image

This helps when there are significant API changes (which might be coming up in future xbatcher releases), and people need to refer back to older versions like v0.1.0.

Describe alternatives you've considered

Keep the status quo of just 'latest' and 'stable'.

Additional context

The readthedocs setting is documented at https://docs.readthedocs.io/en/stable/versions.html. If I'm not mistaken, it should involve unchecking the 'Single version' box at https://readthedocs.org/dashboard/xbatcher/advanced?

image

Also, it should be possible to build previous tagged versions (v0.1.0, v0.2.0) at https://readthedocs.org/projects/xbatcher/versions/

@maxrjones
Copy link
Member

Seems like a good idea to me! That box is already unchecked, but I could look into this more or add you to the project on readthedocs if you're interested in working on it.

@weiji14
Copy link
Member Author

weiji14 commented Dec 9, 2022

Hmm, maybe the setting is somewhere else. If you add me as a maintainer (my readthedocs username is same as on GitHub), I'll try to find it. I knew I had to do it in weiji14/zen3geo#13, but forgot exactly how 😅

@weiji14
Copy link
Member Author

weiji14 commented Dec 9, 2022

Thanks Max for the invite! I think I've figured it out, the steps are:

  1. Go to https://readthedocs.org/projects/xbatcher/versions/
  2. Under 'Activate a version', select a tag (e.g. v0.2.0) and click on 'Activate'
  3. Check the 'Activate' box and click 'Save'
    Activating the v0.2.0 docs build
  4. Wait for the tagged versions to build, see progress under https://readthedocs.org/projects/xbatcher/builds
    Builds triggered for tags v0.2.0 and 0.1.0

Not sure if we have to manually trigger this for every tagged release (I don't recall having to do it for zen3geo), but yeah, here are the tagged builds:

Closing this issue as completed.

@weiji14 weiji14 closed this as completed Dec 9, 2022
@maxrjones
Copy link
Member

Super, thanks @weiji14!

@maxrjones
Copy link
Member

reopening in order to add the version switcher to the pydata theme configuration (https://pydata-sphinx-theme.readthedocs.io/en/stable/user_guide/version-dropdown.html#version-switcher-dropdowns)

@maxrjones maxrjones reopened this Jan 7, 2023
@maxrjones
Copy link
Member

Fixed by #152

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants