CP-308455 VM.sysprep CA-414158 wait for "action" key to disappear

[lindig]

The code misses the timeout exception becaue of we are using a module alias.

[edwintorok]

That is a bit unexpected, that alias is not a real module alias then.

[last-genius]

I'm a bit confused here, why would this not work?

[lindig]

We are all a bit surprised. A simple repro does work as intended. It could be related to functors or dune. The code below works as expected.

module Outer = struct
  module Inner = struct
    exception E

    let f () = raise E
  end
end

let main () =
  let module I = Outer.Inner in
  try 
    I.f ()
  with
    I.E -> print_endline "gotcha"

let () = main ()

[edwintorok]

We need to confirm that the test was indeed running the latest code, and not some older version that lacked the exception handler, otherwise sounds like a compiler bug if we can reproduce it, but like Christian said a simple repro attempt works as expected.

[lindig]

The test failure was on this code:

let trigger ~domid ~uuid ~timeout =
  let open Ezxenstore_core.Xenstore in
  let module Watch = Ezxenstore_core.Watch in
  let control = Printf.sprintf "/local/domain/%Ld/control/sysprep" domid in
  let domain = Printf.sprintf "/local/domain/%Ld" domid in
  with_xs (fun xs ->
      xs.Xs.write (control // "filename") "d://unattend.xml" ;
      xs.Xs.write (control // "vdi-uuid") uuid ;
      xs.Xs.write (control // "action") "sysprep" ;
      debug "%s: notified domain %Ld" __FUNCTION__ domid ;
      try
        (* wait for sysprep to start, then domain to dissapear *)
        Watch.(
          wait_for ~xs ~timeout:5.0
            (value_to_become (control // "action") "running")
        ) ;
        debug "%s: sysprep is runnung; waiting for sysprep to finish"
          __FUNCTION__ ;
        Watch.(wait_for ~xs ~timeout (key_to_disappear (control // "action"))) ;
        debug "%s sysprep is finished" __FUNCTION__ ;
        Watch.(wait_for ~xs ~timeout (key_to_disappear domain)) ;
        true
      with Watch.Timeout _ ->
        debug "%s: sysprep timeout" __FUNCTION__ ;
        false
  )