-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: walkthroughs/VM.start: Update the xenguest chapter (domain build) #6272
doc: walkthroughs/VM.start: Update the xenguest chapter (domain build) #6272
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great to see this, thank you very much!
b31f1e4
to
ba30beb
Compare
baa3e21
to
bf16439
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@robhoes: Done as suggested: Removed the links to not "offical" source repositories.
Signed-off-by: Bernhard Kaindl <bernhard.kaindl@cloud.com>
bf16439
to
9ef7e19
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was a small update for improving the structure.
Update the chapter 3.1 title to:
3.1 Interface to xenguest for building domains
At then end of it, add a brief summary on the platform data passed to xenguest:
When called to build a domain,
xenguest
reads those and builds the VM accordingly.
Add a new chapter heading to describe what the content of the remaining lines:
3.2 Workflow for allocating and populating domain memory
@robhoes Can we merge this? |
@last-genius I haven't reviewed the text myself, but if other have then I'm happy for this to get merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @last-genius and @psafont!
@robhoes wrote #6272 (comment) for merging this PR:
@last-genius I haven't reviewed the text myself, but if other have then I'm happy for this to get merged.
If you could kindly add a comment that you reviewed the text, @robhoes would be open for merging it.
For your review, please find a preview of the docs with this PR here:
https://bernhard-xapi-onrender-com-pr-7.onrender.com/xenopsd/walkthroughs/VM.start/index.html#2-create-a-xen-domain
~Bernhard
PS:
How the preview was generated:
I configured a fork of this repository for automatic Hugo previews on http://render.com using this blueprint: https://github.com/bernhard-xapi/bernhard-xapi.onrender.com/blob/main/render.yaml. After enabling previews for pull requests , I got this preview site created automatically after opening a local PR in the repository. This is the PR showing the creation of the preview site: bernhard-xapi#7 (it only supports local pull requests within the repository, so I had to create a local PR for it)
PPS:
I'm thankful that this small team created a documentation site that is accessible and well-maintained and helps newcomers to understand the miracles this software does.
I do think that this documentation is an great asset that is very helpful to understand how the individual parts work. For example, the Xen hypervisor does not have such a single integrated documentation site for all things Xen.
I am happy with the docs, so merging it. |
Update:
Update and extend the walkthrough of
VM.start
:xenopsd
functions from xapi-project/xenopsd.git to the current xenopsd code in xapi-project/xen-api.gitxenguest then uses this in the
build` phase to build the domain.xenguest
into a dedicated chapter onxenguest
.xenopsd
passes toxenguest
for the domain buildxenguest
takes to build the domain.