CA-405628: unmount/detach PVS cache VDI before destroying #6266
+19
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psafont
reviewed
Feb 3, 2025
lindig
approved these changes
Feb 3, 2025
The pvsproxy daemon normally unmounts and removes the locally attached VBD for the cache VDI when needed. We do it as well in `PVS_cache_storage.destroy`, just in case pvsproxy did not manage to, for whatever reason. This should avoid any VDI_IN_USE errors. Signed-off-by: Rob Hoes <rob.hoes@citrix.com>
psafont
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pvsproxy daemon normally unmounts and removes the locally attached VBD for the cache VDI when needed. We do it as well in
PVS_cache_storage.destroy, just in case pvsproxy did not manage to, for whatever reason. This should avoid any VDI_IN_USE errors.