Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CA-400924 - networkd: Add bonds to devs in network_monitor_thread #6075

Merged

Conversation

last-genius
Copy link
Contributor

Without it, stats for bond's interfaces are not identified correctly.

Fixes: bd4dda5 (IH-715 - rrdp-netdev: Remove double (de)serialization)

Without it, stats for bond's interfaces are not identified correctly.

Fixes: bd4dda5 (IH-715 - rrdp-netdev: Remove double (de)serialization)

Signed-off-by: Andrii Sultanov <andrii.sultanov@cloud.com>
@last-genius
Copy link
Contributor Author

This works, tested manually:

Before the fix:

# xe pif-list params=carrier,device
device ( RO)     : eth0
    carrier ( RO): true


device ( RO)     : bond0
    carrier ( RO): false


device ( RO)     : eth1
    carrier ( RO): false

After:

xe pif-list params=carrier,device
device ( RO)     : eth0
    carrier ( RO): true


device ( RO)     : bond0
    carrier ( RO): true


device ( RO)     : eth1
    carrier ( RO): false

(Same in XenCenter, which shows link status as 'connected' after the fix,
and 'disconnected' before)

The failing test is now also passing, XenRT job #4135142

@lindig lindig added this pull request to the merge queue Oct 23, 2024
Merged via the queue into xapi-project:master with commit 46f0f42 Oct 23, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants