Add Makefile.xcp that creates RPMs. #1

magthe · 2010-12-16T10:36:28Z

No description provided.

matthiasgoergens · 2011-01-31T22:35:11Z

Someone should review the top-three commits (I am too tired). The lower ones (Adding the .gitginore and the css-file) seem harmless.

xen-git · 2011-04-05T15:44:00Z

Failed to merge and build magthe/xen-api@`dd19cc7` with `ac556ef`.

Failed when executing:
git merge dd19cc7
Error log:
requesting all changes
adding changesets
adding manifests
adding file changes
added 1677 changesets with 3604 changes to 636 files
updating to branch default
180 files updated, 0 files merged, 0 files removed, 0 files unresolved
ln -sf /usr/groups/xen/carbon/trunk/latest/manifest /local/builds/build-xen-git.hg/obj/manifest.input
======> 1302018223 api: cloning xen-api.git from git@github.com:xen-git
======> 1302018223 api: WARNING - no personal fork of xen-api. Cloning from git://hg.uk.xensource.com/git instead.
Initialized empty Git repository in /local/builds/build-xen-git.hg/myrepos/xen-api/.git/
======> 1302018239 api: xen-api placed into myrepos
Auto-merging ocaml/idl/OMakefile
CONFLICT (content): Merge conflict in ocaml/idl/OMakefile
Auto-merging ocaml/lvhdrt/OMakefile
CONFLICT (content): Merge conflict in ocaml/lvhdrt/OMakefile
Auto-merging xapi.spec
CONFLICT (content): Merge conflict in xapi.spec
Automatic merge failed; fix conflicts and then commit the result.

xen-git · 2011-04-05T20:02:17Z

Build succeeded. Can merge magthe/xen-api@`c264ab1` with `ac556ef`.

xen-git · 2011-04-08T00:06:02Z

Build succeeded. Can merge magthe/xen-api@`c264ab1` with `486794e`.

zli · 2011-04-08T10:30:39Z

ocaml/idl/OMakefile

+	if test -f $(JQUERY); then \
+		cp $(JQUERY) $(SDK)/docs/html; \
+	else; \
+		(cd $(SDK)/docs/html; wget http://jqueryjs.googlecode.com/files/jquery-1.1.3.1.pack.js); \


Is it good to download missing files directly from the build system? This might hide the fact if the files were really missed.

If it's for built outside our building system (e.g. XCP), I guess JonL must have already made some changes (e.g. on $CARBON_DISTFILES) to his Makefile variants in XCP branch.

The same for the next patch hunk.

As you see the current build system assumes that the JQuery file is available from the filesystem (which AFAIK only holds true when building at Citrix).

Downloading the file during build is probably not so good, but it's arguably better than relying on the build happening at Citrix :-)

As I said, it's probably already addressed/generlized in JonL's XCP building scripts which will eventually merge or substitute this one.

I would suggest to just leave this part as it is for now, or to issue an warning message to tell the user to define $CARBON_DISTFILES him/herself and place jquery (and possibly many other dependencies as well) in the right place.

Then I'll just close the pull request completely and we'll wait for Jon's merge instead.

jonludlam · 2011-04-08T11:59:05Z

We should remove jquery entirely. It's no longer needed.

xen-git · 2011-04-08T12:34:50Z

Build succeeded. Can merge magthe/xen-api@`c264ab1` with `fb197f0`.

xen-git · 2011-04-08T13:02:01Z

Build succeeded. Can merge magthe/xen-api@`c264ab1` with `2d3391e`.

Updates to the xenops interface

Xcp_service refactoring

install missing qemu-vif-script

s/Stringext/Xstringext/g

CP-5169: Updated repository name. Replaced hg_loc with git_loc so the component can be cuilt correctly

Functorize, add unit tests

Update to use rpclib rather than a bespoke xmlrpc lib

CA-111132: Make xcp-rrdd-iostat handle empty VBDs

Switch order of the data source/owner tuple

Add protocol choice

rrddump: Update for stdext 2.0.0

Add standard files.

Add all the standard files.

Use Api_messages to get message priority

Add initial boilerplate

CA-302981, CP-30032: Timeout on XAPI calls, and sandbox varstore-rm

Optionally use the message switch

Add some mirror commands

lib/xenstore: preserve logging from Xs_client_unix

This enables PAM to be used in multithreaded mode (currently XAPI has a global lock around auth). Using an off-cpu flamegraph I identified that concurrent PAM calls are slow due to a call to `sleep(1)`. `pam_authenticate` calls `crypt_r` which calls `NSSLOW_Init` which on first use will try to initialize the just `dlopen`-ed library. If it encounters a race condition it does a `sleep(1)`. This race condition can be quite reliably reproduced when performing a lot of PAM authentications from multiple threads in parallel. GDB can also be used to confirm this by putting a breakpoint on `sleep`: ``` #0 __sleep (seconds=seconds@entry=1) at ../sysdeps/unix/sysv/linux/sleep.c:42 #1 0x00007ffff1548e22 in freebl_RunLoaderOnce () at lowhash_vector.c:122 #2 0x00007ffff1548f31 in freebl_InitVector () at lowhash_vector.c:131 #3 NSSLOW_Init () at lowhash_vector.c:148 #4 0x00007ffff1b8f09a in __sha512_crypt_r (key=key@entry=0x7fffd8005a60 "pamtest-edvint", salt=0x7ffff31e17b8 "dIJbsXKc0", #5 0x00007ffff1b8d070 in __crypt_r (key=key@entry=0x7fffd8005a60 "pamtest-edvint", salt=<optimized out>, #6 0x00007ffff1dc9abc in verify_pwd_hash (p=p@entry=0x7fffd8005a60 "pamtest-edvint", hash=<optimized out>, nullok=nullok@entry=0) at passverify.c:111 #7 0x00007ffff1dc9139 in _unix_verify_password (pamh=pamh@entry=0x7fffd8002910, name=0x7fffd8002ab0 "pamtest-edvint", p=0x7fffd8005a60 "pamtest-edvint", ctrl=ctrl@entry=8389156) at support.c:777 #8 0x00007ffff1dc6556 in pam_sm_authenticate (pamh=0x7fffd8002910, flags=<optimized out>, argc=<optimized out>, argv=<optimized out>) at pam_unix_auth.c:178 #9 0x00007ffff7bcef1a in _pam_dispatch_aux (use_cached_chain=<optimized out>, resumed=<optimized out>, h=<optimized out>, flags=1, pamh=0x7fffd8002910) at pam_dispatch.c:110 #10 _pam_dispatch (pamh=pamh@entry=0x7fffd8002910, flags=1, choice=choice@entry=1) at pam_dispatch.c:426 #11 0x00007ffff7bce7e0 in pam_authenticate (pamh=0x7fffd8002910, flags=flags@entry=1) at pam_auth.c:34 #12 0x00000000005ae567 in XA_mh_authorize (username=username@entry=0x7fffd80028d0 "pamtest-edvint", password=password@entry=0x7fffd80028f0 "pamtest-edvint", error=error@entry=0x7ffff31e1be8) at xa_auth.c:83 #13 0x00000000005adf20 in stub_XA_mh_authorize (username=<optimized out>, password=<optimized out>) at xa_auth_stubs.c:42 ``` `pam_start` and `pam_end` doesn't help here, because on `pam_end` the library is `dlclose`-ed, so on next `pam_authenticate` it will have to go through the initialization code again. (This initialization code would've belonged into `pam_start`, not `pam_authenticate`, but there are several layers here including a call to `crypt_r`). Upstream has fixed this problem >5 years ago by switching to libxcrypt instead. Signed-off-by: Edwin Török <edwin.torok@cloud.com>

First release

Add standard files.

CA-107919: Reduce memory usage when writing large RRDs.

Backport of 3b52b72 This enables PAM to be used in multithreaded mode (currently XAPI has a global lock around auth). Using an off-cpu flamegraph I identified that concurrent PAM calls are slow due to a call to `sleep(1)`. `pam_authenticate` calls `crypt_r` which calls `NSSLOW_Init` which on first use will try to initialize the just `dlopen`-ed library. If it encounters a race condition it does a `sleep(1)`. This race condition can be quite reliably reproduced when performing a lot of PAM authentications from multiple threads in parallel. GDB can also be used to confirm this by putting a breakpoint on `sleep`: ``` #0 __sleep (seconds=seconds@entry=1) at ../sysdeps/unix/sysv/linux/sleep.c:42 xapi-project#1 0x00007ffff1548e22 in freebl_RunLoaderOnce () at lowhash_vector.c:122 xapi-project#2 0x00007ffff1548f31 in freebl_InitVector () at lowhash_vector.c:131 xapi-project#3 NSSLOW_Init () at lowhash_vector.c:148 xapi-project#4 0x00007ffff1b8f09a in __sha512_crypt_r (key=key@entry=0x7fffd8005a60 "pamtest-edvint", salt=0x7ffff31e17b8 "dIJbsXKc0", xapi-project#5 0x00007ffff1b8d070 in __crypt_r (key=key@entry=0x7fffd8005a60 "pamtest-edvint", salt=<optimized out>, xapi-project#6 0x00007ffff1dc9abc in verify_pwd_hash (p=p@entry=0x7fffd8005a60 "pamtest-edvint", hash=<optimized out>, nullok=nullok@entry=0) at passverify.c:111 xapi-project#7 0x00007ffff1dc9139 in _unix_verify_password (pamh=pamh@entry=0x7fffd8002910, name=0x7fffd8002ab0 "pamtest-edvint", p=0x7fffd8005a60 "pamtest-edvint", ctrl=ctrl@entry=8389156) at support.c:777 xapi-project#8 0x00007ffff1dc6556 in pam_sm_authenticate (pamh=0x7fffd8002910, flags=<optimized out>, argc=<optimized out>, argv=<optimized out>) at pam_unix_auth.c:178 xapi-project#9 0x00007ffff7bcef1a in _pam_dispatch_aux (use_cached_chain=<optimized out>, resumed=<optimized out>, h=<optimized out>, flags=1, pamh=0x7fffd8002910) at pam_dispatch.c:110 xapi-project#10 _pam_dispatch (pamh=pamh@entry=0x7fffd8002910, flags=1, choice=choice@entry=1) at pam_dispatch.c:426 xapi-project#11 0x00007ffff7bce7e0 in pam_authenticate (pamh=0x7fffd8002910, flags=flags@entry=1) at pam_auth.c:34 xapi-project#12 0x00000000005ae567 in XA_mh_authorize (username=username@entry=0x7fffd80028d0 "pamtest-edvint", password=password@entry=0x7fffd80028f0 "pamtest-edvint", error=error@entry=0x7ffff31e1be8) at xa_auth.c:83 xapi-project#13 0x00000000005adf20 in stub_XA_mh_authorize (username=<optimized out>, password=<optimized out>) at xa_auth_stubs.c:42 ``` `pam_start` and `pam_end` doesn't help here, because on `pam_end` the library is `dlclose`-ed, so on next `pam_authenticate` it will have to go through the initialization code again. (This initialization code would've belonged into `pam_start`, not `pam_authenticate`, but there are several layers here including a call to `crypt_r`). Upstream has fixed this problem >5 years ago by switching to libxcrypt instead. Signed-off-by: Edwin Török <edwin.torok@cloud.com> Signed-off-by: Christian Lindig <christian.lindig@cloud.com>

Backport of 3b52b72 This enables PAM to be used in multithreaded mode (currently XAPI has a global lock around auth). Using an off-cpu flamegraph I identified that concurrent PAM calls are slow due to a call to `sleep(1)`. `pam_authenticate` calls `crypt_r` which calls `NSSLOW_Init` which on first use will try to initialize the just `dlopen`-ed library. If it encounters a race condition it does a `sleep(1)`. This race condition can be quite reliably reproduced when performing a lot of PAM authentications from multiple threads in parallel. GDB can also be used to confirm this by putting a breakpoint on `sleep`: ``` #0 __sleep (seconds=seconds@entry=1) at ../sysdeps/unix/sysv/linux/sleep.c:42 #1 0x00007ffff1548e22 in freebl_RunLoaderOnce () at lowhash_vector.c:122 #2 0x00007ffff1548f31 in freebl_InitVector () at lowhash_vector.c:131 #3 NSSLOW_Init () at lowhash_vector.c:148 #4 0x00007ffff1b8f09a in __sha512_crypt_r (key=key@entry=0x7fffd8005a60 "pamtest-edvint", salt=0x7ffff31e17b8 "dIJbsXKc0", #5 0x00007ffff1b8d070 in __crypt_r (key=key@entry=0x7fffd8005a60 "pamtest-edvint", salt=<optimized out>, #6 0x00007ffff1dc9abc in verify_pwd_hash (p=p@entry=0x7fffd8005a60 "pamtest-edvint", hash=<optimized out>, nullok=nullok@entry=0) at passverify.c:111 #7 0x00007ffff1dc9139 in _unix_verify_password (pamh=pamh@entry=0x7fffd8002910, name=0x7fffd8002ab0 "pamtest-edvint", p=0x7fffd8005a60 "pamtest-edvint", ctrl=ctrl@entry=8389156) at support.c:777 #8 0x00007ffff1dc6556 in pam_sm_authenticate (pamh=0x7fffd8002910, flags=<optimized out>, argc=<optimized out>, argv=<optimized out>) at pam_unix_auth.c:178 #9 0x00007ffff7bcef1a in _pam_dispatch_aux (use_cached_chain=<optimized out>, resumed=<optimized out>, h=<optimized out>, flags=1, pamh=0x7fffd8002910) at pam_dispatch.c:110 #10 _pam_dispatch (pamh=pamh@entry=0x7fffd8002910, flags=1, choice=choice@entry=1) at pam_dispatch.c:426 #11 0x00007ffff7bce7e0 in pam_authenticate (pamh=0x7fffd8002910, flags=flags@entry=1) at pam_auth.c:34 #12 0x00000000005ae567 in XA_mh_authorize (username=username@entry=0x7fffd80028d0 "pamtest-edvint", password=password@entry=0x7fffd80028f0 "pamtest-edvint", error=error@entry=0x7ffff31e1be8) at xa_auth.c:83 #13 0x00000000005adf20 in stub_XA_mh_authorize (username=<optimized out>, password=<optimized out>) at xa_auth_stubs.c:42 ``` `pam_start` and `pam_end` doesn't help here, because on `pam_end` the library is `dlclose`-ed, so on next `pam_authenticate` it will have to go through the initialization code again. (This initialization code would've belonged into `pam_start`, not `pam_authenticate`, but there are several layers here including a call to `crypt_r`). Upstream has fixed this problem >5 years ago by switching to libxcrypt instead. Signed-off-by: Edwin Török <edwin.torok@cloud.com> Signed-off-by: Christian Lindig <christian.lindig@cloud.com>

magthe added 3 commits April 5, 2011 20:51

rpmbuild, step one.

5c65f4d

Deal with stuff that is in distfiles. Not complete.

3c45b81

Adjusting mode to non-Windows sanity.

c264ab1

zli reviewed Apr 8, 2011
View reviewed changes

magthe closed this Apr 8, 2011

ghost mentioned this pull request Jun 11, 2014

CA-121347: Fix inconsistency in HA checks #1788

Merged

ghost mentioned this pull request Sep 5, 2014

CA-121347: Fix inconsistency in HA checks #1914

Merged

sharady pushed a commit to sharady/xen-api that referenced this pull request May 11, 2015

Merge pull request xapi-project#1 from jonludlam/xapi-updates

8b9955d

Updates to the xenops interface

sharady pushed a commit to sharady/xen-api that referenced this pull request May 11, 2015

Merge pull request xapi-project#1 from vbmithr/master

b584e80

Xcp_service refactoring

koushikcgit pushed a commit to koushikcgit/xen-api that referenced this pull request Aug 7, 2015

Merge pull request xapi-project#1 from avsm/master

8f64d9b

install missing qemu-vif-script

johnelse mentioned this pull request Nov 4, 2015

CA-183272: Improving Dom0 mem usage alert mail text #2481

Merged

lippirk referenced this pull request in lippirk/xen-api Jul 20, 2020

Merge pull request #1 from jonludlam/great_stringext_rename

507ca11

s/Stringext/Xstringext/g

kc284 added a commit to kc284/xen-api that referenced this pull request Mar 11, 2021

Merge pull request xapi-project#1 from kc284/master

649eea7

CP-5169: Updated repository name. Replaced hg_loc with git_loc so the component can be cuilt correctly

robhoes pushed a commit that referenced this pull request Jul 19, 2021

Merge pull request #1 from djs55/functorize

14d2ab8

Functorize, add unit tests

robhoes pushed a commit that referenced this pull request Jul 19, 2021

Merge pull request #1 from jonludlam/rpclib

8aef5a9

Update to use rpclib rather than a bespoke xmlrpc lib

robhoes pushed a commit that referenced this pull request Sep 14, 2021

Merge pull request #1 from jjd27/master

bddd993

CA-111132: Make xcp-rrdd-iostat handle empty VBDs

robhoes pushed a commit that referenced this pull request Sep 14, 2021

Merge pull request #1 from johnelse/switch-ds-tuple

8034c6a

Switch order of the data source/owner tuple

robhoes pushed a commit that referenced this pull request Sep 14, 2021

Merge pull request #1 from johnelse/protocol-choice

cee0e9e

Add protocol choice

robhoes pushed a commit that referenced this pull request Sep 14, 2021

Merge pull request #1 from euanh/master

3dc412c

rrddump: Update for stdext 2.0.0

robhoes pushed a commit that referenced this pull request Sep 21, 2021

Merge pull request #1 from xen-org/add-standard-files

fff3e0a

Add standard files.

robhoes pushed a commit that referenced this pull request Sep 22, 2021

Merge pull request #1 from djs55/first-release

72b97d7

Add all the standard files.

robhoes pushed a commit that referenced this pull request Oct 21, 2021

Merge pull request #1 from johnelse/api-messages

b98305d

Use Api_messages to get message priority

robhoes pushed a commit that referenced this pull request Jan 10, 2022

Merge pull request #1 from djs55/boilerplate

53a16f2

Add initial boilerplate

edwintorok referenced this pull request in edwintorok/xen-api Jan 10, 2022

Merge pull request #1 from edwintorok/private/edvint/sandbox2

95f7df1

CA-302981, CP-30032: Timeout on XAPI calls, and sandbox varstore-rm

robhoes pushed a commit that referenced this pull request Jan 10, 2022

Merge pull request #1 from djs55/xenswitch

b538b18

Optionally use the message switch

robhoes pushed a commit that referenced this pull request Jan 10, 2022

Merge pull request #1 from jonludlam/mirror-cmds

ef28320

Add some mirror commands

stormi mentioned this pull request Mar 10, 2022

RFC: improved UEFI Secure Boot certificates management in XAPI #4647

Closed

psafont pushed a commit that referenced this pull request Apr 11, 2023

Merge pull request #1 from jjd27/master

0c267bf

lib/xenstore: preserve logging from Xs_client_unix

psafont pushed a commit that referenced this pull request Jan 31, 2024

Merge pull request #1 from djs55/first-release

54e3129

First release

psafont pushed a commit that referenced this pull request Jan 31, 2024

Merge pull request #1 from djs55/first-release

55ec27b

Add standard files.

psafont pushed a commit that referenced this pull request Jan 31, 2024

Merge pull request #1 from jonludlam/CA-107919

92959e5

CA-107919: Reduce memory usage when writing large RRDs.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Makefile.xcp that creates RPMs. #1

Add Makefile.xcp that creates RPMs. #1

magthe commented Dec 16, 2010

matthiasgoergens commented Jan 31, 2011

xen-git commented Apr 5, 2011

xen-git commented Apr 5, 2011

xen-git commented Apr 8, 2011

zli Apr 8, 2011

magthe Apr 8, 2011

zli Apr 8, 2011

magthe Apr 8, 2011

jonludlam commented Apr 8, 2011

xen-git commented Apr 8, 2011

xen-git commented Apr 8, 2011

Add Makefile.xcp that creates RPMs. #1

Add Makefile.xcp that creates RPMs. #1

Conversation

magthe commented Dec 16, 2010

matthiasgoergens commented Jan 31, 2011

xen-git commented Apr 5, 2011

Failed to merge and build magthe/xen-api@dd19cc7 with ac556ef.

xen-git commented Apr 5, 2011

Build succeeded. Can merge magthe/xen-api@c264ab1 with ac556ef.

xen-git commented Apr 8, 2011

Build succeeded. Can merge magthe/xen-api@c264ab1 with 486794e.

zli Apr 8, 2011

Choose a reason for hiding this comment

magthe Apr 8, 2011

Choose a reason for hiding this comment

zli Apr 8, 2011

Choose a reason for hiding this comment

magthe Apr 8, 2011

Choose a reason for hiding this comment

jonludlam commented Apr 8, 2011

xen-git commented Apr 8, 2011

Build succeeded. Can merge magthe/xen-api@c264ab1 with fb197f0.

xen-git commented Apr 8, 2011

Build succeeded. Can merge magthe/xen-api@c264ab1 with 2d3391e.

Failed to merge and build magthe/xen-api@`dd19cc7` with `ac556ef`.

Build succeeded. Can merge magthe/xen-api@`c264ab1` with `ac556ef`.

Build succeeded. Can merge magthe/xen-api@`c264ab1` with `486794e`.

Build succeeded. Can merge magthe/xen-api@`c264ab1` with `fb197f0`.

Build succeeded. Can merge magthe/xen-api@`c264ab1` with `2d3391e`.