In XSI-1969 we deal with an inconsistent Xapi DB and fail to recognise a
PCI as SRIOV. Be more lenient and recognise stale PCI refs as SRIOV.
Also remove a VM from a VGPU explictly on resouce cleanup.

Signed-off-by: Christian Lindig <christian.lindig@citrix.com>

In XSI-1969 we deal with an inconsistent Xapi DB and fail to recognise a
PCI as SRIOV. Be more lenient and recognise stale PCI refs as SRIOV.
Also remove a VM from a VGPU explictly on resouce cleanup.

The secure boot status can be read from the fifth byte of file
/sys/firmware/efi/efivars/SecureBoot-8be4df61-93ca-11d2-aa0d-00e098032b8c

This adds a secure_boot field to the host datamodel, which is set
during dbsync to the value held in the above file.

Signed-off-by: Christian Pardillo Laursen <christian.pardillolaursen@cloud.com>

The secure boot status can be read from the fifth byte of file
/sys/firmware/efi/efivars/SecureBoot-8be4df61-93ca-11d2-aa0d-00e098032b8c

This adds a secure_boot field to the host datamodel, which is set during
dbsync to the value held in the above file.

When serving files, a filename can be hinted to the client, so they can
download the with the correct filename instead of showing the contents
on the screen. For example, with `curl -JO`.

Don't change behaviour unless explicitly requested, users like the xapi
fileserver serve html files which are not meant to be downloaded.

See https://httpwg.org/specs/rfc6266.html#rfc.section.4.2

Signed-off-by: Pau Ruiz Safont <pau.safont@vates.tech>

Signed-off-by: Pau Ruiz Safont <pau.safont@vates.tech>

There were several unuseful debug messages, reduce loglines to the error
ones that may help debug an error situation.

Signed-off-by: Pau Ruiz Safont <pau.safont@vates.tech>

This allows to fix the case where the call to the endpoint failed
without parameters. Now the correct mimetypes are offered for each of
the filetypes, and the filename offered when using tar has the correct
extension.

Signed-off-by: Pau Ruiz Safont <pau.safont@vates.tech>

Allows to see the relation between its parameters, and show the
differences in how xen-bugtool is invoked

Signed-off-by: Pau Ruiz Safont <pau.safont@vates.tech>

Previously both methods to collect the file handled errors in a slightly
different way. Use the same code for both to be consistent

Signed-off-by: Pau Ruiz Safont <pau.safont@vates.tech>

Now the filenames are ordered by date and hostname

Examples:
```
content-disposition: attachment; filename="system_status-2025-09-29T13:23:13Z-metavega.tar"
content-disposition: attachment; filename="system_status-2025-09-29T13:24:30Z-metavega.zip"
```

Signed-off-by: Pau Ruiz Safont <pau.safont@vates.tech>

This allows the clients to request only the entries they are interested
in.

This is done by adding `?list` to the URL:

```
$ curl -k -i -H "cookie: session_id=OpaqueRef:XXX" https://metavega/system-status?list
HTTP/1.1 200 OK
content-length: 6373
connection: close
cache-control: no-cache, no-store
Server: xapi/25.27
content-type: application/xml

[...]
```

Signed-off-by: Pau Ruiz Safont <pau.safont@vates.tech>

OCaml 5 is particularly picky here and wants all those dependencies
explicitly (and tediously) declared, otherwise it will print
`ocaml_deprecated_auto_include` alerts. In the case of `unix`, it is
used nearly everywhere.

Signed-off-by: Rob Hoes <rob.hoes@citrix.com>

The format of the error that this test checks for is printed a little
differently by the OCaml 5 compiler (the name of the tag is now quoted).
Adapt the test a little to make it work both for OCaml 4 and 5.

Signed-off-by: Rob Hoes <rob.hoes@citrix.com>

Signed-off-by: Rob Hoes <rob.hoes@citrix.com>

Now there's no failure when called without parameters, suggests a nice
filename with the correct extension, advertises the content-type of the
file served, and adds an option to list all the allowed entries
supported by xen-bugtool in an xml format.

Signed-off-by: Andrii Sultanov <andriy.sultanov@vates.tech>

…efaults

This enables client.ml to skip specifying an arbitrary number of rightmost
arguments if they're all equal to their default values (since arguments are
positional, once an argument is not skipped, no arguments to its left can be
skipped).

Generated code for e.g. host.disable looks like the following:

  let session_id = rpc_of_ref_session session_id in
  let host = rpc_of_ref_host host in
  let auto_enable = rpc_of_bool auto_enable in

  let needed_args, _ = List.fold_right2
    (fun param default (acc, skipped)->
      (* Since arguments are positional, we can only skip specifying an
         argument that's equal to its default value if all the arguments to
         its right were also not specified *)
      if skipped then
        (match default with
        | Some default_value when param = default_value -> (acc, true)
        | _ -> (param::acc, false))
      else
        (param :: acc, false)
    ) [ session_id; host; auto_enable ] [ None; None; Some (Rpc.Bool true) ] ([], true)
  in

  rpc_wrapper rpc "host.disable" needed_args >>= fun x -> return (ignore x)

This fixes an issue with client.ml always specifying values for new parameters
that older server.ml did not know about (which happens during an RPU).

Fixes: cf5be62 ("host.disable: Add auto_enabled parameter for persistency")

Signed-off-by: Andrii Sultanov <andriy.sultanov@vates.tech>

… defaults (#6693)

#6652 added a new parameter
to `Host.disable`. Since the method is used during an RPU, when a new
client calls an older server unaware of the parameter, this broke it.
Add a test reproducing what happens during an RPU and fix the issue in
`client.ml`.

---

Adds an older `server.ml` and `client.ml` from xapi 25.30.0 (with
`server.ml`
modified to compile after the XSA-474 interface changes), before
`Host.disable`
gained the `auto_enable` parameter.

Adds compatibility tests verifying that an older client can talk to a
newer
server and the other way around.

Before the fix, both `test_compatibility_with_old_server_*` fail,
showing that
`auto_enable` in `Host.disable` is an unexpected parameter. This failure
is
triggered on RPUs, when a newer xapi talks to an older one:

[exception] Server_error(MESSAGE_PARAMETER_COUNT_MISMATCH, [
host.disable; 1; 2 ])

So allow `client.ml` to skip specifying an arbitrary number of rightmost
arguments if they're all equal to their default values (since arguments
are
positional, once an argument is not skipped, no arguments to its left
can be
skipped).

Generated code for `host.disable` looks like the following:

```
let session_id = rpc_of_ref_session session_id in
let host = rpc_of_ref_host host in
let auto_enable = rpc_of_bool auto_enable in

let needed_args, _ = List.fold_right2
 (fun param default (acc, skipped)->
   (* Since arguments are positional, we can only skip specifying an
      argument that's equal to its default value if all the arguments to
      its right were also not specified *)
   if skipped then
     (match default with
     | Some default_value when param = default_value -> (acc, true)
     | _ -> (param::acc, false))
   else
     (param :: acc, false)
 ) [ session_id; host; auto_enable ] [ None; None; Some (Rpc.Bool true) ] ([], true)
in

rpc_wrapper rpc "host.disable" needed_args >>= fun x -> return (ignore x)
```

This fixes an issue with `client.ml` always specifying values for new
parameters
that older `server.ml` did not know about (which happens during an RPU).

This makes `test_compatibility_with_old_server_default` pass, so drop
the
`try with` for it. `test_compatibility_with_old_server_non_default`
still fails,
indicating that everything works as intended.

Fixes: cf5be62 ("host.disable: Add auto_enabled parameter for
persistency")