Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: xapi-project/xen-api
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v25.3.0
Choose a base ref
...
head repository: xapi-project/xen-api
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v25.4.0
Choose a head ref
  • 17 commits
  • 23 files changed
  • 4 contributors

Commits on Jan 26, 2025

  1. docs: Update doc/README.md and Hugo Relearn (to 5.23.0 for now)

    Minor updates of the Hugo documentation:
    
    - The current Ubuntu snap package of Hugo is not supported by the docs.
      We should take a first minor step towards fixing this.
    
    - `doc/README.md` is outdated and should be updated.
      It says that the Ubuntu snap of Hugo works, but it does not anymore.
      Fix this by updating the outdated information.
    
    - An initial fix is to update the Relearn theme from 5.20.x to 5.23.0:
      - It does not introduce breaking changes.
      - It introduces more straightforward page links and deprecates older syntax.
      - Fix the warnings by updating relative links accordingly.
    
    Signed-off-by: Bernhard Kaindl <bernhard.kaindl@cloud.com>
    bernhardkaindl committed Jan 26, 2025
    Configuration menu
    Copy the full SHA
    458b138 View commit details
    Browse the repository at this point in the history

Commits on Jan 27, 2025

  1. Fix currently broken links to toolstack/features: HA, snapshots

    Signed-off-by: Bernhard Kaindl <bernhard.kaindl@cloud.com>
    bernhardkaindl committed Jan 27, 2025
    Configuration menu
    Copy the full SHA
    7010a98 View commit details
    Browse the repository at this point in the history
  2. Update 3 links to the hierachy of the new-docs site

    Signed-off-by: Bernhard Kaindl <bernhard.kaindl@cloud.com>
    bernhardkaindl committed Jan 27, 2025
    Configuration menu
    Copy the full SHA
    26264f9 View commit details
    Browse the repository at this point in the history
  3. docs: Update docs/README.md and Hugo Relearn to 5.23.0 (#6251)

    Minor updates of the Hugo documentation:
    
    - The current Ubuntu `snap` package of Hugo is not supported by the
    docs.
      We should take a first minor step towards fixing this.
    
    -
    [`doc/README.md`](https://github.com/xapi-project/xen-api/blob/master/doc/README.md)
    is outdated and should be updated ([new
    version](https://github.com/xenserver-next/xen-api/blob/docs-update-README-and-hugo-relearn-to-5.23/doc/README.md)).
      It says that the Ubuntu snap of Hugo works, but it does not anymore.
      Fix this by updating the outdated information.
    
    - An initial fix is to update the Relearn theme from 5.20.x to 5.23.0:
      - It does not introduce breaking changes.
    - It introduces more straightforward page links and deprecates older
    syntax.
      - Fix the warnings by updating relative links accordingly.
    
    A preview is available on my site:
    https://xenserver-next.github.io/xen-api/index.html
    robhoes authored Jan 27, 2025
    Configuration menu
    Copy the full SHA
    0499324 View commit details
    Browse the repository at this point in the history
  4. CI: When only Hugo docs change, other workflows do not need to run

    Signed-off-by: Bernhard Kaindl <bernhard.kaindl@cloud.com>
    bernhardkaindl committed Jan 27, 2025
    Configuration menu
    Copy the full SHA
    3a6a64e View commit details
    Browse the repository at this point in the history
  5. Hugo docs: Fix {{site.baseurl}} links to use relative internal links …

    …instead
    
    Signed-off-by: Bernhard Kaindl <bernhard.kaindl@cloud.com>
    bernhardkaindl committed Jan 27, 2025
    Configuration menu
    Copy the full SHA
    ea9372f View commit details
    Browse the repository at this point in the history

Commits on Jan 28, 2025

  1. CA-403759: Initialise licensing after no-other-masters check

    When the coordinator restarts. the no-other-masters check in the startup
    sequence does two things for each pool member:
    
    1. It checks that the host agrees that it is are not the coordinator.
    2. It unblocks the host's master_connection thread, which is likely waiting
       for a reconnection delay to expire, which may be up to 256 seconds
       (exponential backoff is used). The delay is interrupted to
       immediately unblock DB calls.
    
    Licensing initialisation comes earlier in the startup sequence, but
    under certain circumstance make calls to other host, in particular after
    an upgrade. A this time, hosts may still be blocked on the
    master_connection for up to 256 s, which adds an unnecessary delay to
    the coordinator's startup sequence and therefore the usability of the
    API.
    
    Address this by reversing the order of the two startup actions.
    
    Signed-off-by: Rob Hoes <rob.hoes@citrix.com>
    robhoes committed Jan 28, 2025
    Configuration menu
    Copy the full SHA
    38c3eb5 View commit details
    Browse the repository at this point in the history
  2. master_connection: remove unreachable case

    Signed-off-by: Rob Hoes <rob.hoes@citrix.com>
    robhoes committed Jan 28, 2025
    Configuration menu
    Copy the full SHA
    f78df2e View commit details
    Browse the repository at this point in the history
  3. master_connection: logging once is enough

    Signed-off-by: Rob Hoes <rob.hoes@citrix.com>
    robhoes committed Jan 28, 2025
    Configuration menu
    Copy the full SHA
    f346848 View commit details
    Browse the repository at this point in the history
  4. Hugo docs: Fix {{site.baseurl}} links to use relative internal links …

    …instead (#6255)
    
    For links to internal pages, `{{site.baseurl}}` (without the leading
    `.`) does not
    work in current Hugo, and it is better to replace it by using relative
    links:
    
    `{{.Site.BaseURL}}` is replaced in the rendered output, but it doesn't
    work when
    viewing and editing the files using Markdown editors and viewers like on
    GitHub/Lab
    as well as IDEs with improved support for Markdown editing(in editor and
    preview).
    
    As the relative links work in all cases like in the editors and
    previews,
    fix those (currently broken) links to use the relative links instead.
    
    While at those, also replace the link name "here" with a more specific
    link name.
    
    PS: The only place were `{{.Site.BaseURL}}` or similar is needed is the
    link in
    the `logo.html` template for
    `img="{{.Site.BaseURL}}/images/xapi-project.png"`
    psafont authored Jan 28, 2025
    Configuration menu
    Copy the full SHA
    d6e1139 View commit details
    Browse the repository at this point in the history
  5. CA-403759: Initialise licensing after no-other-masters check (#6257)

    When the coordinator restarts. the no-other-masters check in the startup
    sequence does two things for each pool member:
    
    1. It checks that the host agrees that it is are not the coordinator.
    2. It unblocks the host's master_connection thread, which is likely
    waiting
       for a reconnection delay to expire, which may be up to 256 seconds
       (exponential backoff is used). The delay is interrupted to
       immediately unblock DB calls.
    
    Licensing initialisation comes earlier in the startup sequence, but
    under certain circumstance make calls to other host, in particular after
    an upgrade. A this time, hosts may still be blocked on the
    master_connection for up to 256 s, which adds an unnecessary delay to
    the coordinator's startup sequence and therefore the usability of the
    API.
    
    Address this by reversing the order of the two startup actions.
    robhoes authored Jan 28, 2025
    Configuration menu
    Copy the full SHA
    8a293a0 View commit details
    Browse the repository at this point in the history
  6. CA-400272: pool.set_igmp_snooping_enabled: ignore non-managed PIFs

    The call currently calls `network.attach` on all networks, but this
    fails for PIFs that are not managed by xapi. Simply skip those.
    
    Signed-off-by: Rob Hoes <rob.hoes@citrix.com>
    robhoes committed Jan 28, 2025
    Configuration menu
    Copy the full SHA
    fa6a82c View commit details
    Browse the repository at this point in the history
  7. CA-400272: pool.set_igmp_snooping_enabled: ignore non-managed PIFs (#…

    …6259)
    
    The call currently calls `network.attach` on all networks, but this
    fails for PIFs that are not managed by xapi. Simply skip those.
    robhoes authored Jan 28, 2025
    Configuration menu
    Copy the full SHA
    03e82b6 View commit details
    Browse the repository at this point in the history
  8. Revert "CP-45016: Clean up the source VM earlier"

    This reverts commit 889dfa6. As there
    is no need to clean up the source VM earlier at all, VM_save already
    does the job of deactivating the source VM datapath.
    
    Signed-off-by: Vincent Liu <shuntian.liu2@cloud.com>
    Vincent-lau committed Jan 28, 2025
    Configuration menu
    Copy the full SHA
    bd3024b View commit details
    Browse the repository at this point in the history
  9. CA-405502: Change post_detach to post_deactivate

    Previously the `post_detach_hook` was run after the VDI is detached on
    the source VM, which is at the very end of the SXM, where the source VM
    is shutdown. However, the job of `post_detach_hook` is to call
    `Remote.receive_finalize` which will destroy the mirroring datapath.
    This should have been called as soon as we deactivate the datapath on
    the source VM, at which point the source VM will stop writing using that
    datapath. This commit changes `post_detach_hook` to
    `post_deactivate_hook` and moves its calling locations accordingly.
    
    Signed-off-by: Vincent Liu <shuntian.liu2@cloud.com>
    Vincent-lau committed Jan 28, 2025
    Configuration menu
    Copy the full SHA
    764ec0d View commit details
    Browse the repository at this point in the history

Commits on Jan 29, 2025

  1. CI: When only Hugo docs change, other workflows do not need to run (#…

    …6254)
    
    Optional improvement for fast CI completion when only Hugo docs change
    on push/PRs:
    
    When only Hugo docs change on push and PRs, other workflows can be
    skipped using
    `paths-ignore:` for `docs/**` and `.github/workflows/hugo.yml` to not
    trigger other
    workflows if only these paths change when pushing to a branch / work on
    a PR.
    
    This is completely optional, but would be nice to have when only working
    on Hugo docs.
    It does not change scheduled CI runs. It changes only on-demand push/PR
    workflow runs.
    psafont authored Jan 29, 2025
    Configuration menu
    Copy the full SHA
    08f8647 View commit details
    Browse the repository at this point in the history
  2. Revert VM migration shutdown order change + change post_detach to pos…

    …t_deactivate (#6260)
    
    There are two parts to this PR:
    
    1. Reverts the VM migration ordering change, which was previously
    thought to be necessary as I did not see `VM_save` would actually
    deactivate the source VM datapath. Thanks @edwintorok for pointing that
    out.
    2. Change `post_detach_hook` to `post_deactivate_hook`, as this should
    have been called as soon as the datapath is deactivated, at which point
    all r/w using that datapath will be stopped.
    
    More details in the commit message.
    robhoes authored Jan 29, 2025
    Configuration menu
    Copy the full SHA
    4ea5d43 View commit details
    Browse the repository at this point in the history
Loading