[maintenance]: bool is a keyword in newer C versions, cannot be a parameter

edwintorok · edwintorok · commit 61f79d24e58d · 2025-05-08T15:20:10.000+01:00
Signed-off-by: Edwin Török &lt;edwin.torok@cloud.com&gt;
diff --git a/ocaml/libs/xapi-stdext/lib/xapi-stdext-unix/unixext_stubs.c b/ocaml/libs/xapi-stdext/lib/xapi-stdext-unix/unixext_stubs.c
@@ -39,11 +39,11 @@
 #include "blkgetsize.h"
 
 /* Set the TCP_NODELAY flag on a Unix.file_descr */
-CAMLprim value stub_unixext_set_tcp_nodelay (value fd, value bool)
+CAMLprim value stub_unixext_set_tcp_nodelay (value fd, value nodelay)
 {
-	CAMLparam2 (fd, bool);
+	CAMLparam2 (fd, nodelay);
 	int c_fd = Int_val(fd);
-	int opt = (Bool_val(bool)) ? 1 : 0;
+	int opt = (Bool_val(nodelay)) ? 1 : 0;
 	if (setsockopt(c_fd, IPPROTO_TCP, TCP_NODELAY, (void *)&opt, sizeof(opt)) != 0){
 		uerror("setsockopt", Nothing);
 	}

Original file line number	Diff line number	Diff line change
`@@ -39,11 +39,11 @@`
`39`	`39`	`#include "blkgetsize.h"`
`40`	`40`
`41`	`41`	`/* Set the TCP_NODELAY flag on a Unix.file_descr */`
`42`		`-CAMLprim value stub_unixext_set_tcp_nodelay (value fd, value bool)`
	`42`	`+CAMLprim value stub_unixext_set_tcp_nodelay (value fd, value nodelay)`
`43`	`43`	`{`
`44`		`- CAMLparam2 (fd, bool);`
	`44`	`+ CAMLparam2 (fd, nodelay);`
`45`	`45`	`int c_fd = Int_val(fd);`
`46`		`- int opt = (Bool_val(bool)) ? 1 : 0;`
	`46`	`+ int opt = (Bool_val(nodelay)) ? 1 : 0;`
`47`	`47`	`if (setsockopt(c_fd, IPPROTO_TCP, TCP_NODELAY, (void *)&opt, sizeof(opt)) != 0){`
`48`	`48`	`uerror("setsockopt", Nothing);`
`49`	`49`	`}`