Add System.IdentityModel to Sdk assemblies

[akoeplinger]

Fixes the following mtouch test failure:

Xamarin.Linker.SdkTest.iOS_Classic :   BCL
  Expected:
  But was:  < "System.IdentityModel" >

at NUnit.Framework.CollectionAssert.IsEmpty (IEnumerable collection, System.String message, System.Object[] args) <0x47bec88 + 0x00047> in :0
at NUnit.Framework.CollectionAssert.IsEmpty (IEnumerable collection, System.String message) <0x47bec58 + 0x0001f> in :0
at Xamarin.Linker.SdkTest.BCL (System.String path) <0x47bccf0 + 0x003f3> in :0
at Xamarin.Linker.SdkTest.iOS_Classic () <0x47bcc50 + 0x0001b> in :0

[xamarin-release-manager]

Build failure

[spouliot]

That's fine but I might have been wrong about
#601
crashes being related to the watch simulator. The crash here seems to happen at execution time.

[akoeplinger]

@spouliot yeah. I see this stacktrace in the .crash which to me suggests it's trying to JIT something?

Thread 0 Crashed:: tid_a07  Dispatch queue: com.apple.main-thread
0   libsystem_kernel.dylib          0x04283572 __pthread_kill + 10
1   libsystem_pthread.dylib         0x0424b654 pthread_kill + 101
2   libsystem_c.dylib               0x03fd962d abort + 156
3   com.xamarin.linksdk.watchkitapp.watchkitextension   0x00269d2f monoeg_log_default_handler + 159
4   com.xamarin.linksdk.watchkitapp.watchkitextension   0x00269d97 monoeg_g_log + 103 (goutput.c:112)
5   com.xamarin.linksdk.watchkitapp.watchkitextension   0x0012578b mono_class_load_from_name + 155 (class.c:8015)
6   com.xamarin.linksdk.watchkitapp.watchkitextension   0x00166e79 mono_marshal_get_native_wrapper + 1561 (marshal.c:7796)
7   com.xamarin.linksdk.watchkitapp.watchkitextension   0x0009704d mono_method_to_ir + 160941 (method-to-ir.c:9311)
8   com.xamarin.linksdk.watchkitapp.watchkitextension   0x000f8b25 mini_method_compile + 3317 (mini.c:3547)
9   com.xamarin.linksdk.watchkitapp.watchkitextension   0x000fc1b7 mono_jit_compile_method_inner + 855 (mini.c:4239)
10  com.xamarin.linksdk.watchkitapp.watchkitextension   0x000d6376 mono_jit_compile_method_with_opt + 646 (mini-runtime.c:1914)
11  com.xamarin.linksdk.watchkitapp.watchkitextension   0x000d60e2 mono_jit_compile_method + 50 (mini-runtime.c:1959)
12  com.xamarin.linksdk.watchkitapp.watchkitextension   0x000dc6bf common_call_trampoline + 1055 (mini-trampolines.c:701)
13  com.xamarin.linksdk.watchkitapp.watchkitextension   0x000dd69e mono_vcall_trampoline + 206 (mini-trampolines.c:912)
14  ???                             0x0cad1889 0 + 212670601
15  ???                             0x0000006c 0 + 108
16  ???                             0x0d790e39 0 + 226037305
17  ???                             0x0d790da0 0 + 226037152
18  ???                             0x0d786a10 0 + 225995280
19  ???                             0x0d78f6a0 0 + 226031264
20  ???                             0x0d78668c 0 + 225994380
21  ???                             0x0cb266f8 0 + 213018360
22  ???                             0x0cb265e0 0 + 213018080
23  ???                             0x0cb2657a 0 + 213017978
24  ???                             0x0cb263d8 0 + 213017560
25  ???                             0x0cb262fc 0 + 213017340
26  ???                             0x0cb261cc 0 + 213017036
27  ???                             0x0cb22aa8 0 + 213002920
28  com.xamarin.linksdk.watchkitapp.watchkitextension   0x0026e57d xamarin_register_assembly + 45 (.delegates.inc:99)
29  com.xamarin.linksdk.watchkitapp.watchkitextension   0x0026fc35 register_assembly(_MonoAssembly*, unsigned int*) + 53 (runtime.m:866)
30  com.xamarin.linksdk.watchkitapp.watchkitextension   0x00270723 xamarin_initialize + 1203 (runtime.m:1213)
31  com.xamarin.linksdk.watchkitapp.watchkitextension   0x0027b4bf xamarin_main + 2591 (monotouch-main.m:435)
32  com.xamarin.linksdk.watchkitapp.watchkitextension   0x0027d0bc xamarin_watchextension_main + 124 (main.i386.m:38)

[spouliot]

Seems related to

Aug 16 11:04:30 mac-mini-1 link all[68401]: Runtime critical type Mono.RuntimeStructs/HandleStackMark not found

which is likely new (in master) and without any adjustment to ensure it's preserved by the linker.

[akoeplinger]

Makes sense. @lambdageek can you please take a look at ^ and add the linker preservation magic?

@spouliot since this is unrelated to this PR, any objections to merging?

[lambdageek]

@akoeplinger, @spouliot Sorry about that; will fix it shortly.