[NetworkExtension] Updated completionHandler of handleAppMessage

[dustin-wojciechowski]

HandleAppMessage as it appears in /src/build/Mac/full/NetworkExtension/NETunnelProvider.g.cs after running generator:

Export ("handleAppMessage:completionHandler:")]
[BindingImpl (BindingImplOptions.GeneratedCode | BindingImplOptions.Optimizable)]
public unsafe virtual void HandleAppMessage (
NSData messageData, [BlockProxy(typeof(ObjCRuntime.Trampolines.NIDActionArity1V37))]global::System.Action? completionHandler)

Fixes #16789

[stephen-hawley]

👀

[dustin-wojciechowski]

Per discussion with @mandel-macaque, to have a fix in until we make changes to the Generator, I changed argument of Action in HandleAppMessage signature to instead take new NETunnelAppMessageHandler delegate that contains [NullAllowed] NSData.

Generated code:

In SupportDelegates.cs:

namespace NetworkExtension {
	#nullable enable
        ...
	public delegate void NETunnelAppMessageHandler (NSData? data);
}

In NETunnelProvider.g.cs:

[Export ("handleAppMessage:completionHandler:")]
[BindingImpl (BindingImplOptions.GeneratedCode | BindingImplOptions.Optimizable)]
public unsafe virtual void HandleAppMessage (NSData messageData, [BlockProxy (typeof (ObjCRuntime.Trampolines.NIDNETunnelAppMessageHandler))]NETunnelAppMessageHandler? completionHandler)

[vs-mobiletools-engineering-service2]

🔥 [PR Build] Build failed 🔥

Build failed for the job 'Build packages'

Pipeline on Agent
Hash: $(GIT_HASH) [PR build]

[vs-mobiletools-engineering-service2]

❗ API diff for current PR / commit (Breaking changes)

Legacy Xamarin (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)

• iOS: vsdrops gist (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
• tvOS (no change detected)
• watchOS (no change detected)
• macOS: vsdrops gist (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)

.NET (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)

• iOS: vsdrops gist (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
• tvOS: (empty diff detected)
• MacCatalyst: vsdrops gist (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
• macOS: vsdrops gist (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)

❗ API diff vs stable (Breaking changes)

Legacy Xamarin (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)

• iOS: vsdrops gist (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
• tvOS: vsdrops gist (No breaking changes)
• watchOS: vsdrops gist (No breaking changes)
• macOS: vsdrops gist (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)

.NET (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)

• iOS: vsdrops gist (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
• tvOS: vsdrops gist (No breaking changes)
• MacCatalyst: vsdrops gist (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
• macOS: vsdrops gist (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
• Microsoft.iOS vs Microsoft.MacCatalyst: vsdrops gist

Legacy Xamarin (stable) vs .NET

• iOS: vsdrops gist
• tvOS: vsdrops gist
• macOS: vsdrops gist

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: d3ccd629a3519c1fbbf8d58eeb101a8d9a7bfb91 [PR build]

[rolfbjarne]

This is a breaking change, so we can't do it.

The correct way to do this would be to add a new method overload with the correct signature (the NETunnelAppMessageHandler), and obsolete the old one, but that seems somewhat unnecessary since I believe it's possible to fix the old signature in a backwards compatible way once the generator is fixed.

In other words it might be best to wait until the generator is fixed.