[.NET/CoreVideo] Use [UnmanagedCallersOnly] instead of [MonoPInvokeCallback] Partial Fix for #10470

[stephen-hawley]

straightforward

[rolfbjarne]

Not a big deal, but I think you can use System.Runtime.InteropServices.Unsafe.Unsafe.AsRef<T> here:

xamarin-macios/src/Security/SslConnection.cs

Line 103 in 6590c11

return c.Read (data, ref System.Runtime.CompilerServices.Unsafe.AsRef<nint> (dataLength));

so it becomes something like:

Suggested change

	var returnValue = func (delegateDisplayLink, ref tempInNow, ref tempInOutputTime, flagsIn, ref tempFlagsOut);
	var returnValue = func (delegateDisplayLink, ref System.Runtime.CompilerServices.Unsafe.AsRef<CVTimeStamp> (inNow), ...);

and that way you wouldn't have to create the temporary variables.

[stephen-hawley]

I looked this over in SharpLab and it looks like a win.

[vs-mobiletools-engineering-service2]

🔥 [PR Build] Build failed 🔥

Build failed for the job 'Detect API changes'

Pipeline on Agent
Hash: [PR build]

[vs-mobiletools-engineering-service2]

🔥 Unable to find the contents for the comment: D:\a\1\s\change-detection\results\gh-comment.md does not exist :fire

Pipeline on Agent
Hash: 27c8bbc55bf4a74640991c96b887b2ddc6a3e5ad [PR build]

[vs-mobiletools-engineering-service2]

💻 [PR Build] Tests on macOS Mac Catalina (10.15) passed 💻

✅ All tests on macOS Mac Catalina (10.15) passed.

Pipeline on Agent
Hash: 27c8bbc55bf4a74640991c96b887b2ddc6a3e5ad [PR build]

[vs-mobiletools-engineering-service2]

📚 [PR Build] Artifacts 📚

Packages generated

View packages

• Microsoft.iOS.Bundle.15.4.403-ci.pr.gh15892.pkg
• Microsoft.iOS.Ref.15.4.403-ci.pr.gh15892.nupkg
• Microsoft.iOS.Runtime.ios-arm.15.4.403-ci.pr.gh15892.nupkg
• Microsoft.iOS.Runtime.ios-arm64.15.4.403-ci.pr.gh15892.nupkg
• Microsoft.iOS.Runtime.iossimulator-arm64.15.4.403-ci.pr.gh15892.nupkg
• Microsoft.iOS.Runtime.iossimulator-x64.15.4.403-ci.pr.gh15892.nupkg
• Microsoft.iOS.Runtime.iossimulator-x86.15.4.403-ci.pr.gh15892.nupkg
• Microsoft.iOS.Sdk.15.4.403-ci.pr.gh15892.nupkg
• Microsoft.iOS.Templates.15.4.403-ci.pr.gh15892.nupkg
• Microsoft.iOS.Windows.Sdk.15.4.403-ci.pr.gh15892.nupkg
• Microsoft.MacCatalyst.Bundle.15.4.403-ci.pr.gh15892.pkg
• Microsoft.MacCatalyst.Ref.15.4.403-ci.pr.gh15892.nupkg
• Microsoft.MacCatalyst.Runtime.maccatalyst-arm64.15.4.403-ci.pr.gh15892.nupkg
• Microsoft.MacCatalyst.Runtime.maccatalyst-x64.15.4.403-ci.pr.gh15892.nupkg
• Microsoft.MacCatalyst.Sdk.15.4.403-ci.pr.gh15892.nupkg
• Microsoft.MacCatalyst.Templates.15.4.403-ci.pr.gh15892.nupkg
• Microsoft.macOS.Bundle.12.3.403-ci.pr.gh15892.pkg
• Microsoft.macOS.Ref.12.3.403-ci.pr.gh15892.nupkg
• Microsoft.macOS.Runtime.osx-arm64.12.3.403-ci.pr.gh15892.nupkg
• Microsoft.macOS.Runtime.osx-x64.12.3.403-ci.pr.gh15892.nupkg
• Microsoft.macOS.Sdk.12.3.403-ci.pr.gh15892.nupkg
• Microsoft.macOS.Templates.12.3.403-ci.pr.gh15892.nupkg
• Microsoft.NET.Sdk.iOS.Manifest-6.0.300.15.4.403-ci.pr.gh15892.nupkg
• Microsoft.NET.Sdk.MacCatalyst.Manifest-6.0.300.15.4.403-ci.pr.gh15892.nupkg
• Microsoft.NET.Sdk.macOS.Manifest-6.0.300.12.3.403-ci.pr.gh15892.nupkg
• Microsoft.NET.Sdk.tvOS.Manifest-6.0.300.15.4.403-ci.pr.gh15892.nupkg
• Microsoft.NET.Workload.iOS.15.4.403-ci.pr.gh15892.msi
• Microsoft.tvOS.Bundle.15.4.403-ci.pr.gh15892.pkg
• Microsoft.tvOS.Ref.15.4.403-ci.pr.gh15892.nupkg
• Microsoft.tvOS.Runtime.tvos-arm64.15.4.403-ci.pr.gh15892.nupkg
• Microsoft.tvOS.Runtime.tvossimulator-arm64.15.4.403-ci.pr.gh15892.nupkg
• Microsoft.tvOS.Runtime.tvossimulator-x64.15.4.403-ci.pr.gh15892.nupkg
• Microsoft.tvOS.Sdk.15.4.403-ci.pr.gh15892.nupkg
• Microsoft.tvOS.Templates.15.4.403-ci.pr.gh15892.nupkg
• xamarin.ios-15.13.0.99.pkg
• xamarin.mac-8.13.0.99.pkg

Pipeline on Agent XAMBOT-1042.Monterey'
Hash: 27c8bbc55bf4a74640991c96b887b2ddc6a3e5ad [PR build]

[vs-mobiletools-engineering-service2]

❌ [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) failed ❌

Failed tests are:

• monotouch-test

Pipeline on Agent
Hash: 27c8bbc55bf4a74640991c96b887b2ddc6a3e5ad [PR build]

[vs-mobiletools-engineering-service2]

🚀 [CI Build] Test results 🚀

Test results

✅ All tests passed on VSTS: simulator tests.

🎉 All 223 tests passed 🎉

Tests counts

✅ bcl: All 69 tests passed. Html Report (VSDrops) Download
✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests: All 1 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 7 tests passed. Html Report (VSDrops) Download
✅ framework: All 8 tests passed. Html Report (VSDrops) Download
✅ generator: All 2 tests passed. Html Report (VSDrops) Download
✅ interdependent_binding_projects: All 7 tests passed. Html Report (VSDrops) Download
✅ install_source: All 1 tests passed. Html Report (VSDrops) Download
✅ introspection: All 8 tests passed. Html Report (VSDrops) Download
✅ linker: All 65 tests passed. Html Report (VSDrops) Download
✅ mac_binding_project: All 1 tests passed. Html Report (VSDrops) Download
✅ mmp: All 2 tests passed. Html Report (VSDrops) Download
✅ mononative: All 12 tests passed. Html Report (VSDrops) Download
✅ monotouch: All 23 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ mtouch: All 1 tests passed. Html Report (VSDrops) Download
✅ xammac: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 8 tests passed. Html Report (VSDrops) Download
✅ xtro: All 2 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: [PR build]