Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Windows build perf] LinkNativeCode task is copying SDK tasks that exist on the Mac #19605

Open
Tracked by #19611
emaf opened this issue Dec 8, 2023 · 0 comments
Open
Tracked by #19611
Labels
delighter-sc msbuild Issues affecting our msbuild tasks/targets performance If an issue or pull request is related to performance windows-only The issue only occur on Windows
Milestone

Comments

@emaf
Copy link
Contributor

emaf commented Dec 8, 2023

Steps to Reproduce

LinkNativeCode task is consuming files from Windows that already exist on the Mac. The files are not being copied because of this task because those are chached after the execution of the InstallNameTool task (see #19603), but this is forcing extra checks to verify if the files need to be copied over to the Mac. Also, fixing #19603 could make this task to start copying the files over.

image

Expected Behavior

Actual Behavior

Environment

Version information

Build Logs

Example Project (If Possible)

@emaf emaf added performance If an issue or pull request is related to performance msbuild Issues affecting our msbuild tasks/targets windows-only The issue only occur on Windows labels Dec 8, 2023
@rolfbjarne rolfbjarne added this to the .NET 9 milestone Dec 11, 2023
@rolfbjarne rolfbjarne modified the milestones: .NET 9, .NET 10 Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delighter-sc msbuild Issues affecting our msbuild tasks/targets performance If an issue or pull request is related to performance windows-only The issue only occur on Windows
Projects
None yet
Development

No branches or pull requests

3 participants