Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Windows build perf] Load linker output in a single task #19601

Open
Tracked by #19611
emaf opened this issue Dec 8, 2023 · 1 comment
Open
Tracked by #19611

[Windows build perf] Load linker output in a single task #19601

emaf opened this issue Dec 8, 2023 · 1 comment
Labels
delighter-sc msbuild Issues affecting our msbuild tasks/targets performance If an issue or pull request is related to performance windows-only The issue only occur on Windows
Milestone

Comments

@emaf
Copy link
Contributor

emaf commented Dec 8, 2023

Steps to Reproduce

The _LoadLinkerOutput target is executing many times (~10) the ReadItemsFromFile task remotely. Is this something we could consolidate in a single task/remote call? Each remote execution adds ~200ms to the execution of a task, so in this case we are adding almost 2 secods to the build time just because how this is executed.

image

Expected Behavior

Actual Behavior

Environment

Version information

Build Logs

Example Project (If Possible)

@emaf emaf added performance If an issue or pull request is related to performance msbuild Issues affecting our msbuild tasks/targets windows-only The issue only occur on Windows labels Dec 8, 2023
@rolfbjarne rolfbjarne added this to the .NET 9 milestone Dec 11, 2023
@rolfbjarne
Copy link
Member

Maybe another option could be to copy these files back to Windows, and just read them there instead? I'm not sure what would be faster.

@rolfbjarne rolfbjarne modified the milestones: .NET 9, .NET 10 Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delighter-sc msbuild Issues affecting our msbuild tasks/targets performance If an issue or pull request is related to performance windows-only The issue only occur on Windows
Projects
None yet
Development

No branches or pull requests

3 participants