Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Windows build perf] ILlink should consume .NET assemblies from the Mac installation #19514

Open
Tracked by #19611
emaf opened this issue Nov 22, 2023 · 1 comment
Open
Tracked by #19611
Labels
delighter-sc msbuild Issues affecting our msbuild tasks/targets performance If an issue or pull request is related to performance windows-only The issue only occur on Windows
Milestone

Comments

@emaf
Copy link
Contributor

emaf commented Nov 22, 2023

Steps to Reproduce

Similar to #19511. The task ends up copying .NET assemblies and the Microsoft.iOS.pdb which already exist ont he .NET installation on the Mac

For a new MAUI app, the remote execution is checking and copying around 350 files that are declared that need to be copied to the Mac:
image

Build Logs

Binlogs.zip

@rolfbjarne
Copy link
Member

We're planning on replacing our custom linker steps with other solutions for .NET 9 (#17693), and if we do so, it might be possible to run ILLink on Windows instead of remoting it.

However, we might not be able to finish the custom linker step removal in .NET 9, so we should also look into not copying BCL assemblies to the Mac as suggested.

@rolfbjarne rolfbjarne added performance If an issue or pull request is related to performance msbuild Issues affecting our msbuild tasks/targets windows-only The issue only occur on Windows labels Nov 27, 2023
@rolfbjarne rolfbjarne added this to the .NET 9 milestone Nov 27, 2023
@rolfbjarne rolfbjarne modified the milestones: .NET 9, .NET 10 Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delighter-sc msbuild Issues affecting our msbuild tasks/targets performance If an issue or pull request is related to performance windows-only The issue only occur on Windows
Projects
None yet
Development

No branches or pull requests

3 participants