Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Windows build perf] FindAotCompiler takes too long #19512

Open
Tracked by #19611
emaf opened this issue Nov 22, 2023 · 1 comment
Open
Tracked by #19611

[Windows build perf] FindAotCompiler takes too long #19512

emaf opened this issue Nov 22, 2023 · 1 comment
Labels
delighter-sc msbuild Issues affecting our msbuild tasks/targets performance If an issue or pull request is related to performance windows-only The issue only occur on Windows
Milestone

Comments

@emaf
Copy link
Contributor

emaf commented Nov 22, 2023

When building from Windows, FindAotCompiler sometimes takes aroung 10 seconds to calculate the AOT compile path (if the info is not already cached). It is a bit weird because restoring and running a target should not take that long.

For instance, in this log you can see it took 10.272s in total, and remoting a task takes around 200ms, so the executing itself took around 10 seconds:

image

Build Logs

Binlogs.zip

@rolfbjarne
Copy link
Member

If you set the FindILLinkKeepKeepTemporaryOutput=true property in the csproj, we'll keep the binlogs from the evaluation on the Mac - can you do that and attach these binlogs? That will hopefully clarify a bit better where the time is spent.

@rolfbjarne rolfbjarne self-assigned this Nov 27, 2023
@rolfbjarne rolfbjarne added this to the .NET 9 milestone Nov 27, 2023
@rolfbjarne rolfbjarne added performance If an issue or pull request is related to performance msbuild Issues affecting our msbuild tasks/targets windows-only The issue only occur on Windows labels Nov 27, 2023
@rolfbjarne rolfbjarne removed their assignment Nov 27, 2023
@rolfbjarne rolfbjarne modified the milestones: .NET 9, .NET 10 Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delighter-sc msbuild Issues affecting our msbuild tasks/targets performance If an issue or pull request is related to performance windows-only The issue only occur on Windows
Projects
None yet
Development

No branches or pull requests

3 participants