You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The ODRsTVOS test redirected outside and up to the legacy test directory to reuse it's Assets.xcassets folder.
However, this was causing failures like this:
*** Error: Validation failed for '../../../../SubmissionSamples/ODRsTVOS_Extension/ODRsTVOS/bin/iPhone/Release/ODRsTVOS.ipa'.
*** Error: Missing Info.plist Key. Your app's Info.plist must contain the 'CFBundleIcons.CFBundlePrimaryIcon' key. App
*** Error: Missing Info.plist Key. Your app's Info.plist must contain the 'TVTopShelfImage.TVTopShelfPrimaryImageWide' key. App Store operation failed. (1091)
for the NET6 variant.
After a bunch of msbuild debugging, it turned out that we were not passing these argument to actool:
This seems to be because this check fails when the directory is not next to the csproj.
This issue is to look into that strangeness. Given that it appears to affect legacy just as much as NET6, it is not marked at NET6 issue.
Steps to Reproduce
Undo Add Assets.xcassets to dotnet/ODRsTVOS SubmissionSamples#47 and run SUBMISSION_FILTERS="--filter=ODRsTVOS_Extension" make OR create a project, move the assets out of the folder, and use a redirect ../ to path it outside of the folder, then build and submit the ipa.
Note that - --app-icon "App Icon & Top Shelf Image" - --launch-image LaunchImages are not passed to actool or that the final binary info.plist doesn't have CFBundlePrimaryIcon for example.
Build Logs
This is Legacy with my hack to remove/redirect the asset folder outside the project:
While working on the submission tests, I came across a strange NET6 tv extension test failure:
To quote the work around PR:
This issue is to look into that strangeness. Given that it appears to affect legacy just as much as NET6, it is not marked at NET6 issue.
Steps to Reproduce
SUBMISSION_FILTERS="--filter=ODRsTVOS_Extension" make
OR create a project, move the assets out of the folder, and use a redirect ../ to path it outside of the folder, then build and submit the ipa.- --app-icon "App Icon & Top Shelf Image" - --launch-image LaunchImages
are not passed to actool or that the final binary info.plist doesn't have CFBundlePrimaryIcon for example.Build Logs
This is Legacy with my hack to remove/redirect the asset folder outside the project:
msbuild.binlog.zip
The text was updated successfully, but these errors were encountered: