This repository was archived by the owner on Mar 8, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 8
Commit 86a3d73
committed
Remove extraneous fields that result in false alarm in Mono.Android.xml.
Changes in enumification-helpers and applying the changes from the new tools dotnet/android#1044 results in https://jenkins.mono-project.com/job/xamarin-android-pr-builder/2106/ :
17:49:44 ABI BREAK IN: Mono.Android.dll
17:49:46 <!-- start namespace Android.Views --> <div>
17:49:46 <h2>Namespace Android.Views</h2>
17:49:46 <!-- start type Display --> <div>
17:49:46 <h3>Type Changed: Android.Views.Display</h3>
17:49:46 <p>Removed field:</p>
17:49:46
17:49:46 <pre>
17:49:46 <span class='removed removed-field breaking' data-is-breaking>public static const int StateDozing;</span>
17:49:46 </pre>
17:49:46
17:49:46 </div> <!-- end type Display -->
17:49:46 <!-- start type View --> <div>
17:49:46 <h3>Type Changed: Android.Views.View</h3>
17:49:46 <p>Modified fields:</p>
17:49:46 <pre>
17:49:46 <div data-is-breaking> public const <span class='removed removed-inline removed-breaking-inline'>int</span> <span class='added '>TextAlignment</span> TextAlignmentResolvedDefault = 131072;
17:49:46 </div></pre>
17:49:46
17:49:46 </div> <!-- end type View -->
17:49:46 <!-- start type WindowManagerLayoutParams --> <div>
17:49:46 <h3>Type Changed: Android.Views.WindowManagerLayoutParams</h3>
17:49:46 <p>Removed field:</p>
17:49:46
17:49:46 <pre>
17:49:46 <span class='removed removed-field breaking' data-is-breaking>public static const int TypeKeyguard;</span>
17:49:46 </pre>
17:49:46
17:49:46 </div> <!-- end type WindowManagerLayoutParams -->
17:49:46
17:49:46 </div> <!-- end namespace Android.Views -->
17:49:47
make[2]: *** [check] Error 1
17:49:47 make[1]: *** [run-api-compatibility-tests] Error 2
17:49:47 make: *** [run-all-tests] Error 2
17:49:47 + exit 1
But what are they?
- STATE_DOZING in https://developer.android.com/reference/android/view/Display.html ... it doesn't exist!
- TEXT_ALIGNMENT_RESOLVED_DEFAULT in https://developer.android.com/reference/android/view/View.html ... ditto!
- TYPE_KEYGUARD in https://developer.android.com/reference/android/view/WindowManager.LayoutParams.html ... neither!
They are all false alarm. They should vanish.1 parent c9e7829 commit 86a3d73Copy full SHA for 86a3d73
File tree
Expand file treeCollapse file tree
1 file changed
+395
-96
lines changedFilter options
- reference
Expand file treeCollapse file tree
1 file changed
+395
-96
lines changed
0 commit comments