Skip to content
This repository was archived by the owner on Mar 8, 2021. It is now read-only.

Commit 3de048a

Browse files
jonpryorjonpryor
committed
Update assemblies for mono/mono@d04d534 breakage
Context: https://jenkins.mono-project.com/view/Xamarin.Android/job/xamarin-android/499/API_20Compatibility_20Checks/ The bump to mono/mono@e66c7667 in dotnet/android@b8c30f9e inadvertently broke API compatibility -- overlooked because the API compatibility tests weren't consistently executed; see also dotnet/android@c9d4060a -- and thus it is time to review and approve the API incompatible changes. The `mscorlib.dll` assembly has removed many more `_`-prefixed types, a'la the removal of `System.Runtime.InteropServices._MemberInfo` in commit c704b2a, including: * `System.Runtime.InteropServices._AssemblyBuilder` * `System.Runtime.InteropServices._ConstructorBuilder` * `System.Runtime.InteropServices._CustomAttributeBuilder` * `System.Runtime.InteropServices._EnumBuilder` * `System.Runtime.InteropServices._EventBuilder` * `System.Runtime.InteropServices._FieldBuilder` * `System.Runtime.InteropServices._ILGenerator` * `System.Runtime.InteropServices._LocalBuilder` * `System.Runtime.InteropServices._MethodBase` * `System.Runtime.InteropServices._MethodBuilder` * `System.Runtime.InteropServices._ModuleBuilder` * `System.Runtime.InteropServices._ParameterBuilder` * `System.Runtime.InteropServices._PropertyBuilder` * `System.Runtime.InteropServices._Type` * `System.Runtime.InteropServices._TypeBuilder` The removal of these types resulted in errors such as: <h3>Type Changed: System.Type</h3> <p>Removed interface:</p> <pre> <span class='removed removed-interface breaking' data-is-breaking>Runtime.InteropServices._Type</span> </pre> The removal of these types [has been deemed acceptable][0], because: > we think [such `_`-prefixed types are] so rarely usable and pollutes > core types that [they are] acceptable to break `mscorlib.dll` also elicited errors about the removal of *`virtual`* property overrides such as `System.IO.DirectoryInfo.Exists` and `System.IO.File.Exists`. Removal of `virtual` overrides is not a breaking change. `System.dll` flagged two warnings about the removal of `System.Collections.Generic.Queue<T>` and `System.Collections.Generic.Stack<T>`. These types were moved into `mscorlib.dll`, complete with type forwarders. This move is fine. Update and flush the reference API based on mono/mono@d04d534. [0]: https://xamarinhq.slack.com/archives/C5P3G23NG/p1556642641022900
1 parent c704b2a commit 3de048a

File tree

6 files changed

+3527
-1910
lines changed

6 files changed

+3527
-1910
lines changed

‎reference/Mono.Posix.xml

Lines changed: 1076 additions & 7 deletions
Large diffs are not rendered by default.

‎reference/System.Core.xml

Lines changed: 33 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18790,6 +18790,27 @@
1879018790
<attribute name="System.Runtime.CompilerServices.ExtensionAttribute" />
1879118791
</attributes>
1879218792
<methods>
18793+
<method name="ConfigureAwait(System.Collections.Generic.IAsyncEnumerable`1[T], System.Boolean)" attrib="150" static="true" returntype="System.Runtime.CompilerServices.ConfiguredCancelableAsyncEnumerable`1[T]">
18794+
<attributes>
18795+
<attribute name="System.Runtime.CompilerServices.ExtensionAttribute" />
18796+
</attributes>
18797+
<parameters>
18798+
<parameter name="source" position="0" attrib="0" type="System.Collections.Generic.IAsyncEnumerable`1[T]" direction="this" />
18799+
<parameter name="continueOnCapturedContext" position="1" attrib="0" type="System.Boolean" />
18800+
</parameters>
18801+
<generic-parameters>
18802+
<generic-parameter name="T" attributes="0" />
18803+
</generic-parameters>
18804+
</method>
18805+
<method name="ConfigureAwait(System.IAsyncDisposable, System.Boolean)" attrib="150" static="true" returntype="System.Runtime.CompilerServices.ConfiguredAsyncDisposable">
18806+
<attributes>
18807+
<attribute name="System.Runtime.CompilerServices.ExtensionAttribute" />
18808+
</attributes>
18809+
<parameters>
18810+
<parameter name="source" position="0" attrib="0" type="System.IAsyncDisposable" direction="this" />
18811+
<parameter name="continueOnCapturedContext" position="1" attrib="0" type="System.Boolean" />
18812+
</parameters>
18813+
</method>
1879318814
<method name="Unwrap(System.Threading.Tasks.Task`1[System.Threading.Tasks.Task])" attrib="150" static="true" returntype="System.Threading.Tasks.Task">
1879418815
<attributes>
1879518816
<attribute name="System.Runtime.CompilerServices.ExtensionAttribute" />
@@ -18809,6 +18830,18 @@
1880918830
<generic-parameter name="TResult" attributes="0" />
1881018831
</generic-parameters>
1881118832
</method>
18833+
<method name="WithCancellation(System.Collections.Generic.IAsyncEnumerable`1[T], System.Threading.CancellationToken)" attrib="150" static="true" returntype="System.Runtime.CompilerServices.ConfiguredCancelableAsyncEnumerable`1[T]">
18834+
<attributes>
18835+
<attribute name="System.Runtime.CompilerServices.ExtensionAttribute" />
18836+
</attributes>
18837+
<parameters>
18838+
<parameter name="source" position="0" attrib="0" type="System.Collections.Generic.IAsyncEnumerable`1[T]" direction="this" />
18839+
<parameter name="cancellationToken" position="1" attrib="0" type="System.Threading.CancellationToken" />
18840+
</parameters>
18841+
<generic-parameters>
18842+
<generic-parameter name="T" attributes="0" />
18843+
</generic-parameters>
18844+
</method>
1881218845
</methods>
1881318846
</class>
1881418847
</classes>

‎reference/System.Data.xml

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14812,6 +14812,18 @@
1481214812
</constructor>
1481314813
</constructors>
1481414814
<properties>
14815+
<property name="AccessToken" attrib="0" ptype="System.String">
14816+
<methods>
14817+
<method name="get_AccessToken()" attrib="2182" returntype="System.String">
14818+
<parameters />
14819+
</method>
14820+
<method name="set_AccessToken(System.String)" attrib="2182" returntype="System.Void">
14821+
<parameters>
14822+
<parameter name="value" position="0" attrib="0" type="System.String" />
14823+
</parameters>
14824+
</method>
14825+
</methods>
14826+
</property>
1481514827
<property name="ClientConnectionId" attrib="0" ptype="System.Guid">
1481614828
<methods>
1481714829
<method name="get_ClientConnectionId()" attrib="2182" returntype="System.Guid">

‎reference/System.Net.Http.xml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -733,9 +733,6 @@
733733
</parameters>
734734
</method>
735735
<method name="SendAsync(System.Net.Http.HttpRequestMessage, System.Threading.CancellationToken)" attrib="197" virtual="true" is-override="true" returntype="System.Threading.Tasks.Task`1[System.Net.Http.HttpResponseMessage]">
736-
<attributes>
737-
<attribute name="System.Runtime.CompilerServices.AsyncStateMachineAttribute" />
738-
</attributes>
739736
<parameters>
740737
<parameter name="request" position="0" attrib="0" type="System.Net.Http.HttpRequestMessage" />
741738
<parameter name="cancellationToken" position="1" attrib="0" type="System.Threading.CancellationToken" />

0 commit comments

Comments
 (0)