Skip to content
This repository was archived by the owner on May 29, 2024. It is now read-only.

Bump to xamarin/xamarin-android@2c7d72d2 #41

Merged
merged 1 commit into from
Oct 12, 2022
Merged

Conversation

pjcollins
Copy link
Member

@pjcollins pjcollins commented Oct 11, 2022

Notable documentation related generator changes:

Changes in xamarin-android and java.interop:

Notable documentation related generator changes:

  * dotnet/java-interop@e1ee4b1c: [Java.Interop.Tools.JavaSource] Parse {@param} tags
  * dotnet/java-interop@07c95e96: [Java.Interop.Tools.JavaSource] Parse <code/> tags

Changes in xamarin-android and java.interop:

  * dotnet/android@ca8f561...2c7d72d
  * dotnet/java-interop@a0728ed...e1ee4b1
@opbld33
Copy link

opbld33 commented Oct 11, 2022

Learn Build status updates of commit 267df9e:

⚠️ Validation status: warnings

File Status Preview URL Details
docs/Mono.Android/en/Android.Animation/FloatArrayEvaluator.xml ⚠️Warning View Details
docs/Mono.Android/en/Android.Animation/IntArrayEvaluator.xml ⚠️Warning View Details
docs/Mono.Android/en/Android.Animation/LayoutTransition.xml ⚠️Warning View Details
docs/Mono.Android/en/Android.Animation/PropertyValuesHolder.xml ⚠️Warning View Details
docs/Mono.Android/en/Android.App.Admin/DevicePolicyManager.xml ⚠️Warning View Details
docs/Mono.Android/en/Android.App.Backup/BackupAgent.xml ⚠️Warning View Details
docs/Mono.Android/en/Android.App/Activity.xml ⚠️Warning View Details
docs/Mono.Android/en/Android.App/Fragment.xml ⚠️Warning View Details
docs/Mono.Android/en/Android.App/Notification.xml ⚠️Warning View Details
docs/Mono.Android/en/Android.App/SearchManager.xml ⚠️Warning View Details
docs/Mono.Android/en/Android.Content.PM/PackageManager.xml ⚠️Warning View Details
docs/Mono.Android/en/Android.Content/ContentResolver.xml ⚠️Warning View Details
docs/Mono.Android/en/Android.Content/Context.xml ⚠️Warning View Details
docs/Mono.Android/en/Android.Content/Intent.xml ⚠️Warning View Details
docs/Mono.Android/en/Android.Graphics/Path.xml ⚠️Warning View Details
docs/Mono.Android/en/Android.Hardware/SensorManager.xml ⚠️Warning View Details
docs/Mono.Android/en/Android.Media/AudioManager.xml ⚠️Warning View Details
docs/Mono.Android/en/Android.Media/AudioRecord.xml ⚠️Warning View Details
docs/Mono.Android/en/Android.Print/PrintDocumentAdapter.xml ⚠️Warning View Details
docs/Mono.Android/en/Android.Speech.Tts/TextToSpeech.xml ⚠️Warning View Details
docs/Mono.Android/en/Android.Text/IEditable.xml ⚠️Warning View Details
docs/Mono.Android/en/Android.Transitions/Scene.xml ⚠️Warning View Details
docs/Mono.Android/en/Android.Transitions/Transition.xml ⚠️Warning View Details
docs/Mono.Android/en/Android.Views.Accessibility/AccessibilityNodeInfo.xml ⚠️Warning View Details
docs/Mono.Android/en/Android.Views.Accessibility/AccessibilityNodeProvider.xml ⚠️Warning View Details

This comment lists only the first 25 files in the pull request.

docs/Mono.Android/en/Android.Animation/FloatArrayEvaluator.xml

  • Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'Android.Animation.FloatArrayEvaluator(System.Single[])'.

docs/Mono.Android/en/Android.Animation/IntArrayEvaluator.xml

  • Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'Android.Animation.IntArrayEvaluator(System.Int32[])'.

docs/Mono.Android/en/Android.Animation/LayoutTransition.xml

  • Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'Android.Animation.LayoutTransition.SetAnimator(Android.Animation.LayoutTransitionType,+Android.Animation.Animator)'.

docs/Mono.Android/en/Android.Animation/PropertyValuesHolder.xml

  • Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'Android.Animation.IntArrayEvaluator(System.Int32[])'.
  • Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'Android.Animation.FloatArrayEvaluator(System.Single[])'.

docs/Mono.Android/en/Android.App.Admin/DevicePolicyManager.xml

  • Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'Android.App.Admin.DeviceAdminReceiver.OnLockTaskModeEntering(Android.Content.Context,+Android.Content.Intent,+Android.Content.Intent)'.
  • Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'Android.App.Admin.DeviceAdminReceiver.OnLockTaskModeExiting(Android.Content.Context,+Android.Content.Intent)'.
  • Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'Android.App.Admin.DevicePolicyManager.AddCrossProfileWidgetProvider(Android.Content.ComponentName,+System.String)'.
  • Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'Android.App.Admin.DevicePolicyManager.SetAccountManagementDisabled(Android.Content.ComponentName,+System.String,+System.String)'.
  • Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'Android.App.Admin.DevicePolicyManager.RemoveCrossProfileWidgetProvider(Android.Content.ComponentName,+System.String)'.
  • Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'Android.App.Admin.DevicePolicyManager.AddCrossProfileWidgetProvider(Android.Content.ComponentName,+System.String)'.
  • Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'Android.App.Admin.DevicePolicyManager.RemoveCrossProfileWidgetProvider(Android.Content.ComponentName,+System.String)'.

docs/Mono.Android/en/Android.App.Backup/BackupAgent.xml

  • Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'Android.App.Backup.BackupAgent.OnRestore(Android.App.Backup.BackupDataInput,+System.Int32,+System.Int32)'.
  • Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'Android.App.Backup.BackupAgent.OnRestoreFile(Android.OS.ParcelFileDescriptor,+System.Int64,+System.Int64,+System.Int64,+System.Int64,+System.Int64)'.
  • Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'Android.App.Backup.BackupAgent.FullBackupFile(Java.IO.File,+Android.App.Backup.FullBackupDataOutput)'.
  • Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'Android.App.Backup.BackupAgent.OnRestoreFile(Android.OS.ParcelFileDescriptor,+System.Int64,+System.Int64,+System.Int64,+System.Int64,+System.Int64)'.

docs/Mono.Android/en/Android.App/Activity.xml

  • Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'Android.App.Activity.OnCreateThumbnail(Android.Graphics.Bitmap,+Android.Graphics.Canvas)'.
  • Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'Android.App.Activity.StartActivityForResult(Android.Content.Intent,+System.Int32)'.
  • Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'Android.App.Activity.CreatePendingResult(System.Int32,+Android.Content.Intent,+Android.Content.Intent)'.
  • Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'Android.Content.ContentResolver.Query(Android.Net.Uri,+System.String[],+System.String[],+System.String[],+System.String[])'.
  • Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'Android.App.Activity.OnCreateDialog(System.Int32,+Android.OS.Bundle)'.
  • Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'Android.App.Activity.OnPrepareDialog(System.Int32,+Android.App.Dialog,+Android.App.Dialog)'.
  • Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'Android.App.Activity.ManagedQuery(Android.Net.Uri,+System.String[],+System.String[],+System.String[],+System.String[])'.
  • Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'Android.App.Activity.OnKeyDown(Android.Views.Keycode,+Android.Views.KeyEvent)'.
  • Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'Android.App.Activity.OnPrepareDialog(System.Int32,+Android.App.Dialog,+Android.App.Dialog)'.

This comment lists only the first 25 errors (including error/warning/suggestion) in the pull request.
For more details, please refer to the build report.

If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Learn Build.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

Copy link
Member

@jonathanpeppers jonathanpeppers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to address the warnings above? They might actually be typos in the docs that refer to other types?

@pjcollins
Copy link
Member Author

Do we want to address the warnings above? They might actually be typos in the docs that refer to other types?

I've been trying to chip away at these through improvements to java.interop:

Total Build Warnings
1114

Total Build Suggestions
891

There is a lot to fix though, and the only strict goal I have right now with respect to the docs build report is to ensure that new PRs don't make these numbers worse. The numbers in this report are the same as the report from the last major PR.

Copy link
Member

@jonathanpeppers jonathanpeppers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The main thing I see here is &lt;code&gt; changed to <c>.

There is anything else that changed in the giant diff? 😄

@pjcollins
Copy link
Member Author

pjcollins commented Oct 11, 2022

There is also a fix for a few dozen cases where duplicate params were defined due to the presence of an {@ param} tag. Those extra param elements were replaced with a nested paramref element instead (https://github.com/xamarin/android-api-docs/pull/41/files#diff-18564fa5cda8d8249b99da1017644a77442722a7c1c3a6e243f3e3254854b146R7120)

@pjcollins pjcollins merged commit 52d8515 into main Oct 12, 2022
@pjcollins pjcollins deleted the fix-code-elements branch October 12, 2022 17:48
pjcollins added a commit that referenced this pull request Oct 12, 2022
Notable documentation related generator changes:

  * dotnet/java-interop@e1ee4b1c: [Java.Interop.Tools.JavaSource] Parse `{@param}` tags
  * dotnet/java-interop@07c95e96: [Java.Interop.Tools.JavaSource] Parse `<code/>` tags

Changes in xamarin-android and java.interop:

  * dotnet/android@ca8f561...2c7d72d
  * dotnet/java-interop@a0728ed...e1ee4b1
pjcollins added a commit that referenced this pull request Oct 12, 2022
Notable documentation related generator changes:

  * dotnet/java-interop@e1ee4b1c: [Java.Interop.Tools.JavaSource] Parse `{@param}` tags
  * dotnet/java-interop@07c95e96: [Java.Interop.Tools.JavaSource] Parse `<code/>` tags

Changes in xamarin-android and java.interop:

  * dotnet/android@ca8f561...2c7d72d
  * dotnet/java-interop@a0728ed...e1ee4b1
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants