This repository was archived by the owner on May 29, 2024. It is now read-only.
Update docs using xamarin/java.interop@d3f0c5c6 #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Docs Build status updates of commit fda1236:
|
davidbritch
approved these changes
Dec 10, 2021
jonpryor
reviewed
Dec 10, 2021
| @@ -138,7 +138,7 @@ | |||
| <remarks> | |||
| <para> | |||
| <format type="text/html"> | |||
| <a href="https://developer.android.com/reference/android/animation/ObjectAnimator#ofArgb(java.lang.Object,%20android.util.Property,%20int)" title="Reference documentation">Java documentation for <code>android.animation.ObjectAnimator.ofArgb(java.lang.Object, android.util.Property, int)</code>.</a> | |||
| <a href="https://developer.android.com/reference/android/animation/ObjectAnimator#ofArgb(java.lang.Object,%20android.util.Property,%20int[])" title="Reference documentation">Java documentation for <code>android.animation.ObjectAnimator.ofArgb(java.lang.Object, android.util.Property, int[])</code>.</a> | |||
There was a problem hiding this comment.
Alas, this link is wrong; we actually want:
https://developer.android.com/reference/android/animation/ObjectAnimator#ofArgb(java.lang.Object,%20java.lang.String,%20int...)
Notice trailing ... instead of [].
No idea right now how we know we want ... instead of []; we should file an issue somewhere to track this.
There was a problem hiding this comment.
Filed dotnet/java-interop#931 for this, looks like we have an issue with some overloads too...
jonpryor
reviewed
Dec 10, 2021
| <remarks> | ||
| <para> | ||
| <format type="text/html"> | ||
| <a href="https://developer.android.com/reference/android/animation/ObjectAnimator#ofFloat(java.lang.Object,%20android.util.Property,%20float)" title="Reference documentation">Java documentation for <code>android.animation.ObjectAnimator.ofFloat(java.lang.Object, android.util.Property, float)</code>.</a> | ||
| <a href="https://developer.android.com/reference/android/animation/ObjectAnimator#ofFloat(java.lang.Object,%20android.util.Property,%20android.util.Property,%20android.graphics.Path)" title="Reference documentation">Java documentation for <code>android.animation.ObjectAnimator.ofFloat(java.lang.Object, android.util.Property, android.util.Property, android.graphics.Path)</code>.</a> |
There was a problem hiding this comment.
This link is also wrong :-(
https://developer.android.com/reference/android/animation/ObjectAnimator#ofFloat(T,%20android.util.Property%3CT,%20java.lang.Float%3E,%20android.util.Property%3CT,%20java.lang.Float%3E,%20android.graphics.Path)
which unfortunately means that Java generics are present in the URL signature, which is a different issue that we should track…
There was a problem hiding this comment.
Filed dotnet/java-interop#932
jonpryor
reviewed
Dec 10, 2021
Context: https://github.com/xamarin/java.interop/issues/931
Context: https://github.com/xamarin/java.interop/issues/932
Changes: https://github.com/xamarin/java.interop/compare/087684a70bb71a84c0afb7423c27b50bafb74fb2...aac3e9acca503c38c5616ef84d8af28197da254c
Changes: https://github.com/xamarin/xamarin-android/compare/aea70ca8b12649142bc5dfd0228651c75b56ba50...33a642c7fe78f304fd6aee4a587437f2b088c541
Changes of note:
* `<value/>` has been replaced with `<returns/>`, where appropriate.
* Documentation URLs have been updated to *better* match what the
Android doc link should be.
*Note*: these are not all *correct*; they're often just
"more" correct. See also xamarin/java.interop#931.
No new documentation warnings or suggestions have been introduced:
Total Build Warnings | 1124
Total Build Suggestions | 902 |
This was referenced Dec 10, 2021
pjcollins
changed the title
|
Docs Build status updates of commit 6504743:
|
|
Docs Build status updates of commit f9e3cd9:
|
|
@davidbritch @jonpryor I will have another update coming shortly after this with a bunch of external reference documentation link fixes, but I think we can merge this one as is. I'm also going to try to regenerate the |
pjcollins
added a commit
that referenced
this pull request
Dec 20, 2021
Fixes: dotnet/java-interop#933 Context: dotnet/java-interop#931 Context: dotnet/java-interop#932 Changes: dotnet/java-interop@087684a...d64087c Changes: dotnet/android@aea70ca...05dd813 Changes of note: * Includes a bunch of fixes for method overloads. * Documentation URLs have been updated to *better* match what the Android doc link should be. *Note*: these are still not all *correct*; See dotnet/java-interop#931 and dotnet/java-interop#932. No new documentation warnings or suggestions have been introduced: Total Build Warnings | 1124 Total Build Suggestions | 902
davidbritch
added a commit
that referenced
this pull request
Sep 14, 2022
* Update docs using dotnet/java-interop@d64087cf (#29) Fixes: dotnet/java-interop#933 Context: dotnet/java-interop#931 Context: dotnet/java-interop#932 Changes: dotnet/java-interop@087684a...d64087c Changes: dotnet/android@aea70ca...05dd813 Changes of note: * Includes a bunch of fixes for method overloads. * Documentation URLs have been updated to *better* match what the Android doc link should be. *Note*: these are still not all *correct*; See dotnet/java-interop#931 and dotnet/java-interop#932. No new documentation warnings or suggestions have been introduced: Total Build Warnings | 1124 Total Build Suggestions | 902 * Update docs using dotnet/java-interop@d3f0c5c (#30) Fixes: dotnet/java-interop#931 Fixes: dotnet/java-interop#932 Context: dotnet/java-interop@d3f0c5c Fixes reference documentation URLs for type members with complex parameters. * Master becomes main. * Update docs using dotnet/java-interop@7716ae53 (#33) Updates API docs against: * dotnet/android@bb2f920 * dotnet/java-interop@51c3dae Notable generator improvements include: * dotnet/java-interop@4cbc07a * dotnet/java-interop@13def0e * dotnet/java-interop@32635fd * Update docs using dotnet/android@ace5f71c (#34) Imports Google-provided API-31 Javadoc documentation for nested types that were previously being ignored. Notable documentation related generator changes: * dotnet/java-interop@4b4fedd3: [generator] Process Javadoc for nested types * dotnet/java-interop@265ad762: [Java.Interop.Tools.JavaSource] Fix tag parsing errors Changes in xamarin-android and java.interop: * dotnet/android@c6dcefb...ace5f71 * dotnet/java-interop@7716ae5...032f1e7 * [SEO][Rollout Monikered Canonical]Add URL moniker (#37) Enable build config to generate canonical URL with moniker Co-authored-by: Peter Collins <pecolli@microsoft.com> Co-authored-by: David Britch <davidbritch@users.noreply.github.com> Co-authored-by: Tianqi Zhang <TianqiZhang@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes a bunch of fixes for method overloads.
The following reference documentation issues will
be fixed in a subsequent PR:
dotnet/java-interop#931
dotnet/java-interop#932
Changes in java.interop:
dotnet/java-interop@087684a...d64087c
Changes in xamarin-android:
dotnet/android@aea70ca...05dd813