This repository has been archived by the owner on May 1, 2024. It is now read-only.
Remove extra properties from CarouselView API #7456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hartez
changed the title
rmarinho
approved these changes
Sep 10, 2019
|
|
||
| public static readonly BindableProperty ItemTemplateProperty = | ||
| BindableProperty.Create(nameof(ItemTemplate), typeof(DataTemplate), typeof(ItemsView)); | ||
| // public abstract IItemsLayout ItemsLayout { get; } |
rmarinho
reviewed
Sep 10, 2019
| } | ||
|
|
||
| public static readonly BindableProperty FooterProperty = | ||
| BindableProperty.Create(nameof(Footer), typeof(object), typeof(ItemsView), null); |
There was a problem hiding this comment.
Should be typeof(StructuredItemsView) ?
| @@ -153,13 +153,23 @@ public object PositionChangedCommandParameter | |||
| set => SetValue(PositionChangedCommandParameterProperty, value); | |||
| } | |||
|
|
|||
| public static readonly BindableProperty ItemsLayoutProperty = | |||
There was a problem hiding this comment.
I like how the PR title says "remove properties" when it actually adds some 👍
samhouts
added
the
API-change
samhouts
approved these changes
Sep 12, 2019
rmarinho
approved these changes
Sep 13, 2019
felipebaltazar
pushed a commit
to felipebaltazar/Xamarin.Forms
that referenced
this pull request
Oct 16, 2019
* Remove Header/Footer properties from CarouselView * Limit CarouselView to LinearItemsLayout * Rework inheritance for UWP * Split files by class * Fix up Tizen renderer
felipebaltazar
pushed a commit
to felipebaltazar/Xamarin.Forms
that referenced
this pull request
Oct 16, 2019
* Remove Header/Footer properties from CarouselView * Limit CarouselView to LinearItemsLayout * Rework inheritance for UWP * Split files by class * Fix up Tizen renderer
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
These changes adjust the inheritance tree to move some properties out of CarouselView's API which don't really make sense for the control. Also removes the question of what happens if you try to give the CarouselView a
GridItemsLayout.Also changes
ListItemsLayouttoLinearItemsLayout, which makes more sense for controls like CarouselView.API Changes
ListItemsLayout->LinearItemsLayoutCarouselView:
Removes
Header,HeaderTemplate,Footer,FooterTemplateIItemsLayout ItemsLayout->LinearLayout ItemsLayout.Platforms Affected
Behavioral/Visual Changes
None
Before/After Screenshots
Not applicable
PR Checklist