Prep Page for removal of InternalsVisibleTo #150
Conversation
| { | ||
| get { return EmptyChildren; } | ||
| } | ||
| internal virtual ReadOnlyCollection<Element> LogicalChildrenInternal => EmptyChildren; |
There was a problem hiding this comment.
You may have already considered this but interface definitions can be "overridden" like a virtual method by declaring the interface on the derived class and in that way we wouldn't need Internal methods. There are drawbacks such as having to implement all the other interface methods and not being as explicit without the override keyword. So up to you. https://gist.github.com/kingces95/47a4308e1597e149a214eb6e0daa9d5d
There was a problem hiding this comment.
Seems like that would be problematic for anything that needs to use base. It'd be doable, but kind of a pain for maintenance.
|
👍 with a few suggestions |
hartez
changed the title
hartez
force-pushed
the
ivt-page
branch
2 times, most recently
from
623413a to
92a5d4b
Compare
hartez
changed the title
| @@ -305,7 +308,7 @@ void OnTemplatedItemsChanged(object sender, NotifyCollectionChangedEventArgs e) | |||
|
|
|||
| void Reset() | |||
| { | |||
| List<Element> snapshot = InternalChildren.ToList(); | |||
| List <Element> snapshot = InternalChildren.ToList(); | |||
|
Seems good but 👎 for now because failing a UITest on android, Bugzilla35157.ButtonCanBeClicked |
|
👍 6 green lights! |
Description of Change
Add IPageController interface and update renderers to use it