Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

A11y: Voiceover sequence of elements gets messed up once reaching the end in navigation page #8751

Open
jantanis opened this issue Dec 5, 2019 · 5 comments
Labels
a/a11y 🔍 e/6 🕕 6 i/high Completely doesn't work, crashes, or is unusably slow, has no obvious workaround; occurs less often m/high impact ⬛ p/iOS 🍎 t/bug 🐛 up-for-grabs We welcome community contributions to any issue, but these might be a good place to start!

Comments

@jantanis
Copy link

jantanis commented Dec 5, 2019

Description

When reaching the end of a page in voiceover the reader jumps back, but thing get messy and the original sequence of elements is not abided.

Steps to Reproduce

  1. Open attached solution
  2. Run iOS project on real device
  3. Start screenreader
  4. Swipe throught elements
  5. Continue swiping back and forth after reaching the last item

Expected Behavior

When reaching the last element, you should only be able to swipe back up or reset to first item and index should always be abided.

Actual Behavior

After reaching the last element things get messy when you continue swiping back and forth. You're not able to reach all elements on screen anymore (nav bar title for example)

Basic Information

  • Version with issue: 4.2.0.778463
  • Last known good version: n/a
  • IDE: VS for Mac 8.3.10.2
  • Platform Target Frameworks:
    • iOS: 13.2
  • Affected Devices: iOS

Reproduction Link

A11Y.zip

@jantanis jantanis added s/unverified New report that has yet to be verified t/bug 🐛 labels Dec 5, 2019
@PureWeen PureWeen added a/a11y 🔍 p/iOS 🍎 m/high impact ⬛ and removed s/unverified New report that has yet to be verified labels Dec 7, 2019
@samhouts samhouts added the e/6 🕕 6 label Jan 3, 2020
@samhouts samhouts added i/high Completely doesn't work, crashes, or is unusably slow, has no obvious workaround; occurs less often and removed i/critical labels Feb 13, 2020
@samhouts
Copy link
Member

@jantanis I didn't really see it get stuck when I tested this. I can move back and forth, and I can always get to the title, and it doesn't ever go out of TabIndex order.

However, I do notice that you're putting the TabIndex on the StackLayout but not on the Buttons. This would give the Buttons TabIndex of 0 (default), so they should technically be first. That's a bug that we fix in #9702. StackLayouts are not focusable, so the TabIndex is ignored. Do you expect the children to inherit the layout's TabIndex?

@samhouts samhouts added the s/needs-info ❓ A question has been asked that requires an answer before work can continue on this issue. label Feb 26, 2020
@jantanis
Copy link
Author

@samhouts just tried again on my iPhone 11 Pro, not ok:
https://filebin.net/1ze7gzwi0t2cft5l/RPReplay_Final1582716656.mov?t=a2xzxwmv

Regarding stacklayout tabindex: Yes, it would life make significantly easier if you could "inherit" the tabindex. And as you can see in the screen capture, it does look like it works that way.

@samhouts
Copy link
Member

@jantanis Ok, I'll add inheriting TabIndex as an enhancement. Would you mind testing your solution with https://github.com/xamarin/Xamarin.Forms/files/4248008/Xamarin.Forms.4.4.0.993247.nupkg.zip? to see if it improves the bug you've reported here? Keep in mind that this new package will now focus the elements without a TabIndex first.

Thanks!

@conradh
Copy link

conradh commented Mar 3, 2020

Same problem for us. Quite a showstopper

@jantanis
Copy link
Author

jantanis commented Mar 9, 2020

@jantanis Ok, I'll add inheriting TabIndex as an enhancement. Would you mind testing your solution with https://github.com/xamarin/Xamarin.Forms/files/4248008/Xamarin.Forms.4.4.0.993247.nupkg.zip? to see if it improves the bug you've reported here? Keep in mind that this new package will now focus the elements without a TabIndex first.

Thanks!

@samhouts Looks good to me!

@samhouts samhouts removed the s/needs-info ❓ A question has been asked that requires an answer before work can continue on this issue. label Mar 18, 2020
@samhouts samhouts added this to the 5.0.0 milestone Aug 13, 2020
@samhouts samhouts added inactive Issue is older than 6 months and needs to be retested help wanted We welcome community contributions to any issue, but these might be a good place to start! up-for-grabs We welcome community contributions to any issue, but these might be a good place to start! and removed inactive Issue is older than 6 months and needs to be retested help wanted We welcome community contributions to any issue, but these might be a good place to start! labels Sep 18, 2020
@samhouts samhouts removed this from the 5.0.0 milestone Nov 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
a/a11y 🔍 e/6 🕕 6 i/high Completely doesn't work, crashes, or is unusably slow, has no obvious workaround; occurs less often m/high impact ⬛ p/iOS 🍎 t/bug 🐛 up-for-grabs We welcome community contributions to any issue, but these might be a good place to start!
Projects
None yet
Development

No branches or pull requests

4 participants