Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

TabbedPage.CurrentPage is null for "More" group tabs on iOS #1336

Open
brianlagunas opened this issue Dec 6, 2017 · 4 comments
Open

TabbedPage.CurrentPage is null for "More" group tabs on iOS #1336

brianlagunas opened this issue Dec 6, 2017 · 4 comments
Labels
a/tabbedpage e/10:clock10: 10 i/high Completely doesn't work, crashes, or is unusably slow, has no obvious workaround; occurs less often m/high impact ⬛ p/iOS 🍎 partner Issue submitted by partner or related open source project proposal-open t/enhancement ➕

Comments

@brianlagunas
Copy link

Description

When switching tabs within the "more" group of a TabbedPage on iOS, the CurrentPageChanged event does not fire and the CurrentPage property is not properly set and will return null.

That means there is no way to get the current selected tab if it exists in the “more” group.

Steps to Reproduce

  1. Create a TabbedPage with 7+ tabs (see repo link)
  2. Handle the CurrentPageChanged event and set a break point
  3. Run the app on iOS
  4. Selected various tabs in the "more" group and observe the event never fires and the CurrentPage property is consistently null until you switch to a tab that is not located in the "more" group. Click on the "CurrentPage" button on any of the tabs within the "more" group and notice that no Alert is displayed as the CurrentPage is null. However, select a tab not in the "more" group and click the "CurrentPage" button and the Alert is displayed with the CurrentPage value.

Expected Behavior

The CurrentPageChange event should fire and the CurrentPage property should be set on each tab change regardless of if it exists in the "more" group or not.

Actual Behavior

The CurrentPageChange event does not fire and the CurrentPage is null when selecting tabs in the "more" group on iOS.

Basic Information

  • Version with issue: 2.5.0.77107
  • Last known good version: none
  • IDE: VS2017 15.5
  • Platform Target Frameworks:
    • iOS: 11.1

Reproduction Link

https://github.com/brianlagunas/TabbedPageCurrentPageIssue

@adrianknight89
Copy link
Contributor

I think More is not really supported by Forms. This was because of the fact that the More controller is a navigation controller and any of the tabs under this group can potentially be another navigation controller. To prevent nested navigation controllers, support for this button was never rolled out.

See #573.

@Gh0stC0de
Copy link

Is there any workaround that a tabbed pages ItemsSource can contain more than 5 content pages?

@samhouts samhouts added the partner Issue submitted by partner or related open source project label Sep 21, 2018
@samhouts samhouts added the inactive Issue is older than 6 months and needs to be retested label Dec 20, 2018
@samhouts
Copy link
Member

Last tested with 4.0.0.62955-pre2, and still an issue, but I'm going to reclassify this as an enhancement. Thanks!

@samhouts samhouts added t/enhancement ➕ help wanted We welcome community contributions to any issue, but these might be a good place to start! up-for-grabs We welcome community contributions to any issue, but these might be a good place to start! and removed t/bug 🐛 labels Jan 19, 2019
@samhouts samhouts added i/high Completely doesn't work, crashes, or is unusably slow, has no obvious workaround; occurs less often m/high impact ⬛ inactive Issue is older than 6 months and needs to be retested and removed inactive Issue is older than 6 months and needs to be retested labels Jan 14, 2020
@samhouts samhouts added proposal-open and removed help wanted We welcome community contributions to any issue, but these might be a good place to start! labels Feb 7, 2020
@samhouts samhouts removed the up-for-grabs We welcome community contributions to any issue, but these might be a good place to start! label Feb 7, 2020
@igbenic
Copy link

igbenic commented Mar 16, 2020

Sadly, still having the same problem, is there a way of modifying tabbed page as a workaround? Thank you in advance.

@samhouts samhouts removed the inactive Issue is older than 6 months and needs to be retested label Mar 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
a/tabbedpage e/10:clock10: 10 i/high Completely doesn't work, crashes, or is unusably slow, has no obvious workaround; occurs less often m/high impact ⬛ p/iOS 🍎 partner Issue submitted by partner or related open source project proposal-open t/enhancement ➕
Projects
None yet
Development

No branches or pull requests

5 participants