Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: mergeProps import #68

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rtritto
Copy link

@rtritto rtritto commented Sep 25, 2024

Using eslint-plugin-solid dependency.

Fix

9:20  warning  Prefer importing mergeProps from "solid-js"                                                           solid/imports

@x64Bits
Copy link
Owner

x64Bits commented Sep 27, 2024

Hi @rtritto , can you tell me why this change is necessary? It seems to fix the fact that the solid-js exports for mergeProps have changed, but does it fix anything else?

@rtritto
Copy link
Author

rtritto commented Sep 27, 2024

mergeProps is moved from solid-js/web to solid-js. The import from solid-js/web is deprecated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants