From 21d6c0ad1bc796aa1e5b03d1491339a3bccc4dab Mon Sep 17 00:00:00 2001 From: Michael Noack Date: Mon, 10 Oct 2016 22:20:24 +1030 Subject: [PATCH] Handle unused args --- lib/geokit/core_ext.rb | 2 +- lib/geokit/geocoders.rb | 2 +- lib/geokit/geocoders/mapbox.rb | 4 ++-- lib/geokit/multi_geocoder.rb | 2 +- test/test_base_geocoder.rb | 3 +-- 5 files changed, 6 insertions(+), 7 deletions(-) diff --git a/lib/geokit/core_ext.rb b/lib/geokit/core_ext.rb index cbc771e4..d4559534 100644 --- a/lib/geokit/core_ext.rb +++ b/lib/geokit/core_ext.rb @@ -10,7 +10,7 @@ def try(*a, &b) end class NilClass - def try(*args) + def try(*_args) nil end end diff --git a/lib/geokit/geocoders.rb b/lib/geokit/geocoders.rb index bbd55efc..568826fa 100644 --- a/lib/geokit/geocoders.rb +++ b/lib/geokit/geocoders.rb @@ -145,7 +145,7 @@ def self.call_geocoder_service(url) # Not all geocoders can do reverse geocoding. So, unless the subclass explicitly overrides this method, # a call to reverse_geocode will return an empty GeoLoc. If you happen to be using MultiGeocoder, # this will cause it to failover to the next geocoder, which will hopefully be one which supports reverse geocoding. - def self.do_reverse_geocode(latlng) + def self.do_reverse_geocode(_latlng) GeoLoc.new end diff --git a/lib/geokit/geocoders/mapbox.rb b/lib/geokit/geocoders/mapbox.rb index e8d57e09..979ced84 100644 --- a/lib/geokit/geocoders/mapbox.rb +++ b/lib/geokit/geocoders/mapbox.rb @@ -9,7 +9,7 @@ class MapboxGeocoder < Geocoder private # Template method which does the reverse-geocode lookup. - def self.do_reverse_geocode(latlng, options = {}) + def self.do_reverse_geocode(latlng, _options = nil) latlng = LatLng.normalize(latlng) url = "#{protocol}://api.tiles.mapbox.com/v4/geocode/mapbox.places-v1/" url += "#{latlng.lng},#{latlng.lat}.json?access_token=#{key}" @@ -17,7 +17,7 @@ def self.do_reverse_geocode(latlng, options = {}) end # Template method which does the geocode lookup. - def self.do_geocode(address, options = {}) + def self.do_geocode(address, _options = nil) address_str = address.is_a?(GeoLoc) ? address.to_geocodeable_s : address url = "#{protocol}://api.tiles.mapbox.com/v4/geocode/mapbox.places-v1/" url += "#{Geokit::Inflector.url_escape(address_str)}.json?access_token=#{key}" diff --git a/lib/geokit/multi_geocoder.rb b/lib/geokit/multi_geocoder.rb index c58343b6..ad832bd5 100644 --- a/lib/geokit/multi_geocoder.rb +++ b/lib/geokit/multi_geocoder.rb @@ -45,7 +45,7 @@ def self.do_geocode(address, *args) # This method will call one or more geocoders in the order specified in # the configuration until one of the geocoders work, only this time it's # going to try to reverse geocode a geographical point. - def self.do_reverse_geocode(latlng, *args) + def self.do_reverse_geocode(latlng, *_args) Geokit::Geocoders.provider_order.each do |provider| klass = geocoder(provider) begin diff --git a/test/test_base_geocoder.rb b/test/test_base_geocoder.rb index cec22661..caf9e9fb 100644 --- a/test/test_base_geocoder.rb +++ b/test/test_base_geocoder.rb @@ -3,8 +3,7 @@ # Base class for testing geocoders. class BaseGeocoderTest < Test::Unit::TestCase #:nodoc: all class Geokit::Geocoders::TestGeocoder < Geokit::Geocoders::Geocoder - def self.do_get(url) - sleep(2) + def self.do_get(_url) end end