-
Notifications
You must be signed in to change notification settings - Fork 4
feat: remove --disable-component-update from default args #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Someone in @wxt-dev can review this? 😄 |
@andrea11 What are "components" in this case? I checked out the original puppeteer PR and chrome bug, but neither gave any context |
Hi @aklinker1,
In simpler words, components are pieces of chrome (chromium), that add some features or provides some data dynamically. For example, there is the "Autofill States Data" needed to make the chrome autofill working. Now, as mentioned in my first comments the --disable-component-update prevents any bundled components from being initialised. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the explanation, that makes sense!
Ok so by removing the flag, we're saying that it's ok for the browser to install and initialize these components. Which makes sense for a non-testing/non-automated environment. What does including the flag break for you? |
@aklinker1 I was trying to create an extension using the vite-plugin-web-extension to play with the new (experimental) window.ai API. However, when I started the extension in the dev mode ( |
Yeah, I'll merge it. Just didn't understand the reasoning for it fully, but now I do. I'll merge and release later tonight, on my phone |
Similarly to mozilla#3298,
Quoting:
Disable this flag grant more flexibility, and it can always be disabled via the
web-ext run --arg option
@aklinker1 Could you please check this PR? I would like to propagate the change to your vite-plugin-web-extension