Throw exception from LimitKeyGenerator if no AuthProviders setup

Author: Donald Gray

src/ServiceStack.RateLimit.Redis/LimitKeyGenerator.cs

@@ -3,6 +3,7 @@
 // file, You can obtain one at http://mozilla.org/MPL/2.0/.
 namespace ServiceStack.RateLimit.Redis
 {
+    using System;
     using System.Collections.Generic;
     using Auth;
     using Interfaces;
@@ -48,6 +49,12 @@ public virtual string GetRequestId(IRequest request)
 
         public virtual string GetConsumerId(IRequest request)
         {
+            if (AuthenticateService.AuthProviders == null)
+            {
+                throw new InvalidOperationException(
+                    "AuthService not initialized. This is required for generating default ConsumerId for RateLimitting.");
+            }
+
             IAuthSession userSession = request.GetSession();
 
             // TODO This will need more love to authorize user rather than just verify authentication (not necessarily here but in general)

test/DemoService/AppHost.cs

@@ -37,14 +37,14 @@ public override void Configure(Container container)
 
         private void SetupPlugins()
         {
-            Plugins.Add(new AuthFeature(() => new AuthUserSession(), 
+            /*Plugins.Add(new AuthFeature(() => new AuthUserSession(), 
                 new IAuthProvider[]
                 {
                     new BasicAuthProvider()
-                }));
+                }));*/
 
-            LimitKeyGenerator.Delimiter = ":";
-            LimitKeyGenerator.Prefix = null;
+            /*LimitKeyGenerator.Delimiter = ":";
+            LimitKeyGenerator.Prefix = null;*/
             Plugins.Add(new RateLimitFeature(Container.Resolve<IRedisClientsManager>()));
         }
 

test/DemoService/Program.cs

@@ -26,7 +26,7 @@ public class DemoService : Service
         public object Any(DemoRequest demoRequest) => new DemoResponse { Message = "Response from Demo Service" };
     }
 
-    [Authenticate]
+    //[Authenticate]
     public class DemoRequest : IReturn<DemoResponse>
     {
     }

test/ServiceStack.RateLimit.Redis.Tests/LimitKeyGeneratorTests.cs

@@ -3,6 +3,7 @@
 // file, You can obtain one at http://mozilla.org/MPL/2.0/.
 namespace ServiceStack.RateLimit.Redis.Tests
 {
+    using System;
     using System.Linq;
     using Auth;
     using FakeItEasy;
@@ -20,7 +21,10 @@ public LimitKeyGeneratorTests()
         {
             if (ServiceStackHost.Instance == null)
             {
-                new BasicAppHost().Init();
+                var appHost = new BasicAppHost { TestMode = true }.Init();
+
+                // The GetConsumerId method requires an AuthUserSession.
+                AuthenticateService.Init(() => new AuthUserSession(), new BasicAuthProvider(appHost.AppSettings));
             }
         }
 
@@ -42,10 +46,11 @@ public void GetRequestId_ReturnsOperationName(string operationName)
         [Fact]
         public void GetConsumerId_ThrowsAuthenticationException_IfNotAuthenticated()
         {
-            var request = new MockHttpRequest();
             var keyGenerator = GetGenerator();
 
-            Assert.Throws<AuthenticationException>(() => keyGenerator.GetConsumerId(request));
+            Action action = () => keyGenerator.GetConsumerId(new MockHttpRequest());
+
+            action.ShouldThrow<AuthenticationException>();
         }
 
         [Theory, AutoData]
@@ -174,4 +179,17 @@ private static IAuthSession SetupAuthenticatedSession(string userAuthId, IReques
             return authSession;
         }
     }
+
+    public class LimitKeyGeneratorHostlessTests
+    {
+        [Fact]
+        public void GetConsumerId_ThrowsInvalidOperationException_IfNoAuthProviders()
+        {
+            var keyGenerator = new LimitKeyGenerator();
+
+            Action action = () => keyGenerator.GetConsumerId(new MockHttpRequest());
+
+            action.ShouldThrow<InvalidOperationException>();
+        }
+    }
 }

test/ServiceStack.RateLimit.Redis.Tests/LimitProviderBaseTests.cs

@@ -32,13 +32,15 @@ public LimitProviderBaseTests()
         [Fact]
         public void Ctor_ThrowsArgumentNullException_IfKeyGeneratorNull()
         {
-            Assert.Throws<ArgumentNullException>(() => new LimitProviderBase(null, A.Fake<IAppSettings>()));
+            Action action = () => new LimitProviderBase(null, A.Fake<IAppSettings>());
+            action.ShouldThrow<ArgumentNullException>();
         }
 
         [Fact]
         public void Ctor_ThrowsArgumentNullException_IfAppSettingNull()
         {
-            Assert.Throws<ArgumentNullException>(() => new LimitProviderBase(A.Fake<ILimitKeyGenerator>(), null));
+            Action action = () => new LimitProviderBase(A.Fake<ILimitKeyGenerator>(), null);
+            action.ShouldThrow<ArgumentNullException>();
         }
 
         [Theory, AutoData]

test/ServiceStack.RateLimit.Redis.Tests/RateLimitFeatureTests.cs

@@ -50,7 +50,8 @@ private RateLimitFeature GetSut(bool setupDefaults = true)
         [Fact]
         public void Ctor_ThrowsArgumentNullException_IfRedisManagerNull()
         {
-            Assert.Throws<ArgumentNullException>(() => new RateLimitFeature(null));
+            Action action = () => new RateLimitFeature(null);
+            action.ShouldThrow<ArgumentNullException>();
         }
 
         [Fact]